[GitHub] nswamy commented on a change in pull request #13277: Addressing PR feedback for merging Java API into master

[GitBox <gi...@apache.org>]

nswamy commented on a change in pull request #13277: Addressing PR feedback for merging Java API into master
URL: https://github.com/apache/incubator-mxnet/pull/13277#discussion_r233683596
 
 

 ##########
 File path: scala-package/infer/src/main/scala/org/apache/mxnet/infer/javaapi/ObjectDetector.scala
 ##########
 @@ -41,7 +41,7 @@ import scala.collection.JavaConverters._
   *                           Defaults to CPU.
   * @param epoch              Model epoch to load; defaults to 0
   */
-class ObjectDetector(val objDetector: org.apache.mxnet.infer.ObjectDetector){
+class ObjectDetector private (val objDetector: org.apache.mxnet.infer.ObjectDetector){
 
 Review comment:
   can you make this private[mxnet] instead

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services