You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/30 06:32:01 UTC
[GitHub] [kafka] dongjinleekr opened a new pull request #11720: KAFKA-13625: Fix inconsistency in dynamic application log levels
dongjinleekr opened a new pull request #11720:
URL: https://github.com/apache/kafka/pull/11720
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11720: KAFKA-13625: Fix inconsistency in dynamic application log levels
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11720:
URL: https://github.com/apache/kafka/pull/11720#issuecomment-1029736633
@dongjinleekr Thanks for the explanation. I missed KIP-817 in the mailing list. Let's continue the discussion there and see what the community think about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #11720: KAFKA-13625: Fix inconsistency in dynamic application log levels
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #11720:
URL: https://github.com/apache/kafka/pull/11720#issuecomment-1029440873
Hi @dajac,
Oh yes. As I mentioned in [KIP-817](https://cwiki.apache.org/confluence/display/KAFKA/KIP-817%3A+Fix+inconsistency+in+dynamic+application+log+levels), I already checked [KIP-412](https://cwiki.apache.org/confluence/display/KAFKA/KIP-412%3A+Extend+Admin+API+to+support+dynamic+application+log+levels). But IMHO, I think omitting `OFF` was a mistake; As you can see in the [motivation section in the proposal](https://cwiki.apache.org/confluence/display/KAFKA/KIP-817%3A+Fix+inconsistency+in+dynamic+application+log+levels), I found that `OFF` is helpful when debugging, for the loggers like `kafka.request.logger`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11720: KAFKA-13625: Fix inconsistency in dynamic application log levels
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11720:
URL: https://github.com/apache/kafka/pull/11720#issuecomment-1029400036
@dongjinleekr Thanks for the PR. It seems that OFF was intentionally left out in [KIP-412](https://cwiki.apache.org/confluence/display/KAFKA/KIP-412%3A+Extend+Admin+API+to+support+dynamic+application+log+levels). See the rejected alternative section. Do you think that we should change our mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org