You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/24 14:07:45 UTC

[GitHub] benlamonica commented on issue #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records.

benlamonica commented on issue #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records.
URL: https://github.com/apache/flink/pull/6610#issuecomment-415769746
 
 
   @StephanEwen and @zentol , I've commented on the PR comments. The reason why LatencyMarker has changes is because the equals implementation was incorrect. It did an operatorId != that.operatorId, instead of !operatorId.equals(that.operatorId).
   
   If you want, I can revert that change and just write a more complicated assertEquals statement in the test, but I feel that it is the correct change. The other stream records have equals correctly implemented so that they can compare after a copy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services