You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/16 20:21:39 UTC
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16885
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
[docker] Add support for openSUSE in the Docker build
This patch adds support for openSUSE/leap:15 as a base image in the
Docker build. This is useful for testing and validating Kudu usage on
openSUSE/SLES.
I fixed the logic in `get_os_tag` to handle the illegal `/` character
in the resulting tag. This results in a cleaner tag such as
` apache/kudu:latest-leap15`.
Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
---
M docker/bootstrap-dev-env.sh
M docker/bootstrap-java-env.sh
M docker/bootstrap-python-env.sh
M docker/bootstrap-runtime-env.sh
M docker/docker-build.py
5 files changed, 110 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/16885/1
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
Patch Set 2:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185
PS2, Line 185: update
According to https://en.opensuse.org/images/1/17/Zypper-cheat-sheet-1.pdf , that would be 'refresh', not 'update'. Or 'update' works as well?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185
PS2, Line 185: zypper
Does it make sense to add --non-interactive option to mirror what's done for Debian/Ubuntu?
Also, what about licenses? Is it necessary to do anything interactive in that regard? If so, maybe it's worth adding --auto-agree-with-licenses flag?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@209
PS2, Line 209: openssl-devel
Why openssl isn't enough?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@231
PS2, Line 231: vim
The 'vim' package is already in the fist list, no?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh
File docker/bootstrap-java-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@76
PS2, Line 76: update
refresh ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@76
PS2, Line 76: zypper
Add --non-interactive ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@79
PS2, Line 79: install
Add --non-interactive and --auto-agree-with-licenses ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@82
PS2, Line 82: clean
Add --all ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh
File docker/bootstrap-python-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh@104
PS2, Line 104: zypper
here and below: add --non-interactive flag for zypper?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh@106
PS2, Line 106: update
refresh ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh@117
PS2, Line 117: clean
clean --all ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh
File docker/bootstrap-runtime-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@86
PS2, Line 86: zypper
here and below: add --non-interactive ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@90
PS2, Line 90: install
add --auto-agree-with-licenses ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@95
PS2, Line 95: openssl
Should this be openssl-devel ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@99
PS2, Line 99: install
add --auto-agree-with-licenses ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@105
PS2, Line 105: clean
clean --all ?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/docker-build.py@165
PS2, Line 165: if "/" in base:
nit: it would be nice to add an example for the 'base' which requires extra handling of "/"
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Dec 2020 20:22:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh
File docker/bootstrap-runtime-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@95
PS2, Line 95: openssl
> krb5-devel might be able to be simplified to a smaller runtime only depende
I was curious about the status of those -devel packages: sometimes it seemed like they are in the list for run-time packages, sometimes not. But I guess in most cases I was confusing those environments :)
I'm totally OK if addressing this in a follow-up changelist. And I guess there isn't any rush for that.
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Jan 2021 22:30:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
[docker] Add support for openSUSE in the Docker build
This patch adds support for openSUSE/leap:15 as a base image in the
Docker build. This is useful for testing and validating Kudu usage on
openSUSE/SLES.
I fixed the logic in `get_os_tag` to handle the illegal `/` character
in the resulting tag. This results in a cleaner tag such as
`apache/kudu:latest-leap15`.
Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Reviewed-on: http://gerrit.cloudera.org:8080/16885
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docker/bootstrap-dev-env.sh
M docker/bootstrap-java-env.sh
M docker/bootstrap-python-env.sh
M docker/bootstrap-runtime-env.sh
M docker/docker-build.py
5 files changed, 113 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
Patch Set 2:
(20 comments)
http://gerrit.cloudera.org:8080/#/c/16885/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16885/2//COMMIT_MSG@15
PS2, Line 15:
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185
PS2, Line 185: zypper
> Does it make sense to add --non-interactive option to mirror what's done fo
I don't think we have a license issue given it builds with no problems. The same for interactive modes. I guess this is a case of YAGNI.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185
PS2, Line 185: update
> According to https://en.opensuse.org/images/1/17/Zypper-cheat-sheet-1.pdf
update does a refresh and update and matches the behavior of the other OS variants.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@209
PS2, Line 209: openssl-devel
> Why openssl isn't enough?
This was taken from the install instructions: https://kudu.apache.org/docs/installation.html#sles_from_source
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@220
PS2, Line 220: exta
> nit: extra
Done
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@221
PS2, Line 221: tzdata equivalent package.
> What doesn't work not having this? Could you mention that either in the com
Done
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@231
PS2, Line 231: vim
> The 'vim' package is already in the fist list, no?
Done
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh
File docker/bootstrap-java-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@76
PS2, Line 76: update
> refresh ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@76
PS2, Line 76: zypper
> Add --non-interactive ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@79
PS2, Line 79: install
> Add --non-interactive and --auto-agree-with-licenses ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@82
PS2, Line 82: clean
> Add --all ?
for what?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh
File docker/bootstrap-python-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh@104
PS2, Line 104: zypper
> here and below: add --non-interactive flag for zypper?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh@106
PS2, Line 106: update
> refresh ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-python-env.sh@117
PS2, Line 117: clean
> clean --all ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh
File docker/bootstrap-runtime-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@86
PS2, Line 86: zypper
> here and below: add --non-interactive ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@90
PS2, Line 90: install
> add --auto-agree-with-licenses ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@95
PS2, Line 95: openssl
> Should this be openssl-devel ?
It doesn't appear to be required for runtime.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@99
PS2, Line 99: install
> add --auto-agree-with-licenses ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@105
PS2, Line 105: clean
> clean --all ?
see my other comment on this.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/docker-build.py@165
PS2, Line 165: if "/" in base:
> nit: it would be nice to add an example for the 'base' which requires extra
Done
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 18:25:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 20:55:40 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185
PS2, Line 185: zypper
> OK, but then I'm curious: why do we use DEBIAN_FRONTEND for Ubuntu/Debian
Ubuntu/Debian build hang on the kerberos and tzdata package installs if DEBIAN_FRONTEND isn't used. I don't see that problem here.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh
File docker/bootstrap-java-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@82
PS2, Line 82: clean
> To remove repo metadata as well, I guess. As per https://en.opensuse.org/S
Done
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh
File docker/bootstrap-runtime-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@95
PS2, Line 95: openssl
> Ah, I see -- it seems I confused run-time and development images. Does krb
krb5-devel might be able to be simplified to a smaller runtime only dependency. I would like to do that in a follow up if you are okay with that.
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Jan 2021 15:14:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16885
to look at the new patch set (#4).
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
[docker] Add support for openSUSE in the Docker build
This patch adds support for openSUSE/leap:15 as a base image in the
Docker build. This is useful for testing and validating Kudu usage on
openSUSE/SLES.
I fixed the logic in `get_os_tag` to handle the illegal `/` character
in the resulting tag. This results in a cleaner tag such as
`apache/kudu:latest-leap15`.
Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
---
M docker/bootstrap-dev-env.sh
M docker/bootstrap-java-env.sh
M docker/bootstrap-python-env.sh
M docker/bootstrap-runtime-env.sh
M docker/docker-build.py
5 files changed, 113 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/16885/4
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185
PS2, Line 185: update
> update does a refresh and update and matches the behavior of the other OS v
ack
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185
PS2, Line 185: zypper
> I don't think we have a license issue given it builds with no problems. The
OK, but then I'm curious: why do we use DEBIAN_FRONTEND for Ubuntu/Debian which is similar to --non-interactive for zypper?
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@209
PS2, Line 209: openssl-devel
> This was taken from the install instructions: https://kudu.apache.org/docs/
I see: I was under impression openssl was enough on SLES. Most likely I was wrong, but regardless we should keep this list and the list in the build instructions in sync, I agree.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh
File docker/bootstrap-java-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@82
PS2, Line 82: clean
> for what?
To remove repo metadata as well, I guess. As per https://en.opensuse.org/SDB:Zypper_manual_%28plain%29
clean (cc) [options] [alias|name|#|URI]...
Clean the local caches for all known or specified repositories. By default, only caches of downloaded
packages are cleaned.
-m, --metadata
Clean repository metadata cache instead of package cache.
-M, --raw-metadata
Clean repository raw metadata cache instead of package cache.
-a, --all
Clean both repository metadata and package caches.
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh
File docker/bootstrap-runtime-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@95
PS2, Line 95: openssl
> It doesn't appear to be required for runtime.
Ah, I see -- it seems I confused run-time and development images. Does krb5-devel is needed for runtime?
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 20:22:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16885
to look at the new patch set (#3).
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
[docker] Add support for openSUSE in the Docker build
This patch adds support for openSUSE/leap:15 as a base image in the
Docker build. This is useful for testing and validating Kudu usage on
openSUSE/SLES.
I fixed the logic in `get_os_tag` to handle the illegal `/` character
in the resulting tag. This results in a cleaner tag such as
`apache/kudu:latest-leap15`.
Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
---
M docker/bootstrap-dev-env.sh
M docker/bootstrap-java-env.sh
M docker/bootstrap-python-env.sh
M docker/bootstrap-runtime-env.sh
M docker/docker-build.py
5 files changed, 113 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/16885/3
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
I'll try building this on my Mac.
http://gerrit.cloudera.org:8080/#/c/16885/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16885/2//COMMIT_MSG@15
PS2, Line 15:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@220
PS2, Line 220: exta
nit: extra
http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@221
PS2, Line 221: tzdata equivalent package.
What doesn't work not having this? Could you mention that either in the commit message or somewhere convenient in a comment?
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Dec 2020 20:04:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add support for openSUSE in the Docker build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16885
to look at the new patch set (#2).
Change subject: [docker] Add support for openSUSE in the Docker build
......................................................................
[docker] Add support for openSUSE in the Docker build
This patch adds support for openSUSE/leap:15 as a base image in the
Docker build. This is useful for testing and validating Kudu usage on
openSUSE/SLES.
I fixed the logic in `get_os_tag` to handle the illegal `/` character
in the resulting tag. This results in a cleaner tag such as
` apache/kudu:latest-leap15`.
Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
---
M docker/bootstrap-dev-env.sh
M docker/bootstrap-java-env.sh
M docker/bootstrap-python-env.sh
M docker/bootstrap-runtime-env.sh
M docker/docker-build.py
5 files changed, 111 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/16885/2
--
To view, visit http://gerrit.cloudera.org:8080/16885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680
Gerrit-Change-Number: 16885
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)