You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2001/12/09 04:32:02 UTC
cvs commit: httpd-2.0/modules/experimental config.m4
trawick 01/12/08 19:32:02
Modified: modules/experimental config.m4
Log:
Add -I for the zlib include dir to the right flag variable
Revision Changes Path
1.17 +1 -1 httpd-2.0/modules/experimental/config.m4
Index: config.m4
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/experimental/config.m4,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- config.m4 2001/11/26 22:50:13 1.16
+++ config.m4 2001/12/09 03:32:02 1.17
@@ -53,7 +53,7 @@
ap_save_ldflags=$LDFLAGS
ap_save_libs=$LIBS
if test "$ap_zlib_base" != "/usr"; then
- APR_ADDTO(INCLUDES, [-I${ap_zlib_base}/include])
+ APR_ADDTO(CPPFLAGS, [-I${ap_zlib_base}/include])
APR_ADDTO(LDFLAGS, [-L${ap_zlib_base}/lib])
if test "x$ap_platform_runtime_link_flag" != "x"; then
APR_ADDTO(LDFLAGS, [$ap_platform_runtime_link_flag${ap_zlib_Base}/lib])
Re: cvs commit: httpd-2.0/modules/experimental config.m4
Posted by Jeff Trawick <tr...@attglobal.net>.
"Roy T. Fielding" <fi...@ebuilt.com> writes:
> > Greg? I guess it is preferable to keep it in CPPFLAGS only
> > temporarily (for the test) and put it in INCLUDES once we find that it
> > works?
>
> Yes, unless it is required for later tests. Macros need to save and restore
> any global make variables to avoid polluting later tests.
Cool... I'll try to fix this up tonight.
--
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
Re: cvs commit: httpd-2.0/modules/experimental config.m4
Posted by "Roy T. Fielding" <fi...@ebuilt.com>.
On Mon, Dec 10, 2001 at 07:08:30AM -0500, Jeff Trawick wrote:
> Sascha Schumann <sa...@schumann.cx> writes:
>
> > On Mon, 10 Dec 2001, Greg Stein wrote:
> >
> > > I don't understand why an include doesn't go onto the INCLUDES variable. Why
> > > the shift?
> >
> > I suppose that the include directive is immediately needed
> > for an autoconf cpp check. Autoconf calls the preprocessor
> > with CPPFLAGS, not INCLUDES, and thus it is correct to add
> > the include directive to the former variable.
>
> on the nose! autodetection was failing...
>
> Greg? I guess it is preferable to keep it in CPPFLAGS only
> temporarily (for the test) and put it in INCLUDES once we find that it
> works?
Yes, unless it is required for later tests. Macros need to save and restore
any global make variables to avoid polluting later tests.
....Roy
Re: cvs commit: httpd-2.0/modules/experimental config.m4
Posted by Jeff Trawick <tr...@attglobal.net>.
Sascha Schumann <sa...@schumann.cx> writes:
> On Mon, 10 Dec 2001, Greg Stein wrote:
>
> > I don't understand why an include doesn't go onto the INCLUDES variable. Why
> > the shift?
>
> I suppose that the include directive is immediately needed
> for an autoconf cpp check. Autoconf calls the preprocessor
> with CPPFLAGS, not INCLUDES, and thus it is correct to add
> the include directive to the former variable.
on the nose! autodetection was failing...
Greg? I guess it is preferable to keep it in CPPFLAGS only
temporarily (for the test) and put it in INCLUDES once we find that it
works?
--
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
Re: cvs commit: httpd-2.0/modules/experimental config.m4
Posted by Sascha Schumann <sa...@schumann.cx>.
On Mon, 10 Dec 2001, Greg Stein wrote:
> I don't understand why an include doesn't go onto the INCLUDES variable. Why
> the shift?
I suppose that the include directive is immediately needed
for an autoconf cpp check. Autoconf calls the preprocessor
with CPPFLAGS, not INCLUDES, and thus it is correct to add
the include directive to the former variable.
- Sascha Experience IRCG
http://schumann.cx/ http://schumann.cx/ircg
Re: cvs commit: httpd-2.0/modules/experimental config.m4
Posted by Greg Stein <gs...@lyra.org>.
I don't understand why an include doesn't go onto the INCLUDES variable. Why
the shift?
On Sun, Dec 09, 2001 at 03:32:02AM -0000, trawick@apache.org wrote:
> trawick 01/12/08 19:32:02
>
> Modified: modules/experimental config.m4
> Log:
> Add -I for the zlib include dir to the right flag variable
>
> Revision Changes Path
> 1.17 +1 -1 httpd-2.0/modules/experimental/config.m4
>
> Index: config.m4
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/experimental/config.m4,v
> retrieving revision 1.16
> retrieving revision 1.17
> diff -u -r1.16 -r1.17
> --- config.m4 2001/11/26 22:50:13 1.16
> +++ config.m4 2001/12/09 03:32:02 1.17
> @@ -53,7 +53,7 @@
> ap_save_ldflags=$LDFLAGS
> ap_save_libs=$LIBS
> if test "$ap_zlib_base" != "/usr"; then
> - APR_ADDTO(INCLUDES, [-I${ap_zlib_base}/include])
> + APR_ADDTO(CPPFLAGS, [-I${ap_zlib_base}/include])
> APR_ADDTO(LDFLAGS, [-L${ap_zlib_base}/lib])
> if test "x$ap_platform_runtime_link_flag" != "x"; then
> APR_ADDTO(LDFLAGS, [$ap_platform_runtime_link_flag${ap_zlib_Base}/lib])
>
>
>
--
Greg Stein, http://www.lyra.org/