[GitHub] couchdb-couch issue #230: Add sys db callbacks only once per db open

[nickva <gi...@git.apache.org>]

Github user nickva commented on the issue:

    https://github.com/apache/couchdb-couch/pull/230
  
    It seems functionally there is a difference between the current code path and the new one:
    
    If we don't add callbacks in case db is found, we don't update `Options` to include `sys_db` marker, so then then when we call `update_lru` it won't be inserted it in the LRU. Did we mean to do that?  At least we should mention the side-effect in the commit.
    
    Maybe we want to grab Options from `[#db{fd=Fd, fd_monitor=Lock} = Db] when Lock =/= locked ->` line instead of Options0 then re-run benchmark. Wonder if we are seeing a performance improvement not just directly from `maybe_add_sys_db_callbacks` function not taking more time (it does 3 config reads), but from the side effect of not updating LRU on every open.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---