You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/20 04:10:09 UTC
[GitHub] [incubator-tvm] zhiics opened a new pull request #5112: [docs]
Update relay docs
zhiics opened a new pull request #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112
#5068
This PR updates Relay docs. It removes redundant files and automatically generates automodules.
cc @tqchen @comaniac @cchung100m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5112: [docs] Update
relay docs
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#issuecomment-601980252
Great, let us also add make clean to https://github.com/apache/incubator-tvm/blob/master/tests/scripts/task_python_docs.sh#L47
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics edited a comment on issue #5112: [docs]
Update relay docs
Posted by GitBox <gi...@apache.org>.
zhiics edited a comment on issue #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#issuecomment-601965718
@tqchen Yeah, it should be cached before. `make clean` solves the problem. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5112:
[docs] Update relay docs
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#discussion_r395834803
##########
File path: tutorials/relay_quick_start.py
##########
@@ -79,14 +79,14 @@
# Currently this value can be 0 to 3. The optimization passes include
# operator fusion, pre-computation, layout transformation and so on.
#
-# :any:`relay.build_module.build` returns three components: the execution graph in
+# :any:`relay.build` returns three components: the execution graph in
Review comment:
`:any:->:py:func:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5112: [docs] Update
relay docs
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#issuecomment-601943970
I checked out the image and ran the same command before. It seemed working fine. Hopefully I didn't do something silly. I will double check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #5112: [docs] Update
relay docs
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5112: [docs] Update
relay docs
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#issuecomment-601935444
interesting, can you try to use the exact same docker image? Iet us also try to add make clean before https://github.com/apache/incubator-tvm/blob/master/tests/scripts/task_sphinx_precheck.sh#L36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics edited a comment on issue #5112: [docs]
Update relay docs
Posted by GitBox <gi...@apache.org>.
zhiics edited a comment on issue #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#issuecomment-601913557
@tqchen BTW, the CI still complains about the conflicts from `relay_op.rst` even I removed the `autofunction` there. I couldn't repro it locally. Is it due to some caching problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5112: [docs] Update
relay docs
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#issuecomment-601913557
@tqchen BTW, the CI still complains about the conflict from `relay_op.rst`. I couldn't repro it locally. Is it due to some caching problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5112: [docs] Update
relay docs
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#issuecomment-601965718
@tqchen Yeah, it should be cached before. `make clean` solve the problem. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5112:
[docs] Update relay docs
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#discussion_r395891694
##########
File path: docs/api/python/relay/index.rst
##########
@@ -27,16 +27,22 @@ compiler stack.
.. toctree::
:maxdepth: 2
+ analysis
backend
- base
- build_module
- expr
frontend
image
- analysis
transform
nn
op
- scope_builder
vision
testing
+
+.. automodule:: tvm.relay
+ :members:
+ :imported-members:
+ :exclude-members: RelayExpr, Pass, PassInfo, function_pass, PassContext,
Review comment:
Yeah, I tried this before. But there are a lot of places that directly use the classes without namespace. It causes many ambiguous reference. For example:
https://github.com/apache/incubator-tvm/blob/master/python/tvm/ir/adt.py#L82
`Constructor` here could be `tvm.ir.Constructor` or `tvm.relay.Constructor`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5112:
[docs] Update relay docs
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#discussion_r395834546
##########
File path: docs/api/python/relay/index.rst
##########
@@ -27,16 +27,22 @@ compiler stack.
.. toctree::
:maxdepth: 2
+ analysis
backend
- base
- build_module
- expr
frontend
image
- analysis
transform
nn
op
- scope_builder
vision
testing
+
+.. automodule:: tvm.relay
+ :members:
+ :imported-members:
+ :exclude-members: RelayExpr, Pass, PassInfo, function_pass, PassContext,
Review comment:
We can also consider allow these members, but modify https://github.com/apache/incubator-tvm/blob/master/docs/conf.py#L254 to mark them as alias
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5112:
[docs] Update relay docs
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #5112: [docs] Update relay docs
URL: https://github.com/apache/incubator-tvm/pull/5112#discussion_r395891694
##########
File path: docs/api/python/relay/index.rst
##########
@@ -27,16 +27,22 @@ compiler stack.
.. toctree::
:maxdepth: 2
+ analysis
backend
- base
- build_module
- expr
frontend
image
- analysis
transform
nn
op
- scope_builder
vision
testing
+
+.. automodule:: tvm.relay
+ :members:
+ :imported-members:
+ :exclude-members: RelayExpr, Pass, PassInfo, function_pass, PassContext,
Review comment:
Yeah, I tried this before. But there are a lot of places that directly use the classes without namespace. It causes many ambiguous reference. For example:
https://github.com/apache/incubator-tvm/blob/master/python/tvm/ir/adt.py#L82
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services