You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/30 23:28:54 UTC

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #7625: View Presto row and array objects clearly in the data grid

betodealmeida commented on a change in pull request #7625: View Presto row and array objects clearly in the data grid
URL: https://github.com/apache/incubator-superset/pull/7625#discussion_r289200767
 
 

 ##########
 File path: superset/sql_lab.py
 ##########
 @@ -279,10 +279,17 @@ def execute_sql_statements(
             latest_partition=False)
     query.end_time = now_as_float()
 
+    selected_columns = cdf.columns if cdf.columns else []
 
 Review comment:
   Nit: you can simplify this (and the next line) with
   
   ```python
   selected_columns = cdf.columns or []
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org