You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 11:05:09 UTC

[GitHub] [flink] aljoscha opened a new pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

aljoscha opened a new pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600
 
 
   Before, we were checking for an exact number of restarts, this is too
   strict, because we could have more than the expected number of restarts.
   Now we check whether we have gte the number of expected restarts.
   
   @GJL could you maybe look at this? Or @zentol ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607653638
 
 
   merged

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607185117
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 2d094f2a2800afd7dd250619a2be80589590acbb (Wed Apr 01 11:08:16 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607192706
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d094f2a2800afd7dd250619a2be80589590acbb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha closed pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607192706
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157482874",
       "triggerID" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6931",
       "triggerID" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d094f2a2800afd7dd250619a2be80589590acbb Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157482874) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6931) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607192706
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157482874",
       "triggerID" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6931",
       "triggerID" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d094f2a2800afd7dd250619a2be80589590acbb Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157482874) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6931) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607192706
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157482874",
       "triggerID" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6931",
       "triggerID" : "2d094f2a2800afd7dd250619a2be80589590acbb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d094f2a2800afd7dd250619a2be80589590acbb Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157482874) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6931) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#discussion_r401630599
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -731,7 +731,8 @@ function wait_for_restart_to_complete {
     local expected_num_restarts=$((current_num_restarts + 1))
 
     echo "Waiting for restart to happen"
-    while ! [[ ${current_num_restarts} -eq ${expected_num_restarts} ]]; do
+    while [[ ${current_num_restarts} -le ${expected_num_restarts} ]]; do
 
 Review comment:
   For the record, this should have been `-lt` and it was fixed before pushing to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607191375
 
 
   I'll take a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#issuecomment-607185117
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 2d094f2a2800afd7dd250619a2be80589590acbb (Wed Apr 15 11:39:08 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services