You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2011/11/04 03:03:33 UTC
[jira] [Created] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
-------------------------------------------------------------------------------
Key: MAPREDUCE-3344
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
Project: Hadoop Map/Reduce
Issue Type: Bug
Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
Reporter: Brock Noland
Attachments: MAPREDUCE-3344-1.patch
0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
{code}
// If a back up store is used, reset it
((ReduceContext.ValueIterator)
(context.getValues().iterator())).resetBackupStore();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144428#comment-13144428 ]
Hadoop QA commented on MAPREDUCE-3344:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502254/MAPREDUCE-3344-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1251//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1251//console
This message is automatically generated.
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145768#comment-13145768 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #151 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/151/])
Merge -r 1198909:1198910 from trunk to branch-0.23. Fixes: MAPREDUCE-3344.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198914
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145789#comment-13145789 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #163 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/163/])
Merge -r 1198909:1198910 from trunk to branch-0.23. Fixes: MAPREDUCE-3344.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198914
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145769#comment-13145769 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #1252 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1252/])
MAPREDUCE-3344. o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator. Contributed by Brock Noland.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198910
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated MAPREDUCE-3344:
------------------------------------
Target Version/s: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0, 0.23.0, 0.22.0, 0.21.0)
Status: Patch Available (was: Open)
Patch is ready for review.
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146300#comment-13146300 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #891 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/891/])
MAPREDUCE-3344. o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator. Contributed by Brock Noland.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198910
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145767#comment-13145767 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1326 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1326/])
MAPREDUCE-3344. o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator. Contributed by Brock Noland.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198910
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146265#comment-13146265 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #70 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/70/])
Merge -r 1198909:1198910 from trunk to branch-0.23. Fixes: MAPREDUCE-3344.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198914
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146156#comment-13146156 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #84 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/84/])
Merge -r 1198909:1198910 from trunk to branch-0.23. Fixes: MAPREDUCE-3344.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198914
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144412#comment-13144412 ]
Tom White commented on MAPREDUCE-3344:
--------------------------------------
+1
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146282#comment-13146282 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #857 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/857/])
MAPREDUCE-3344. o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator. Contributed by Brock Noland.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198910
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Tom White (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-3344:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.23.1
0.24.0
Assignee: Brock Noland
Target Version/s: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0, 0.23.0, 0.22.0, 0.21.0)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I've just committed this. Thanks, Brock!
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145804#comment-13145804 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1274 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1274/])
MAPREDUCE-3344. o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator. Contributed by Brock Noland.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198910
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated MAPREDUCE-3344:
------------------------------------
Attachment: MAPREDUCE-3344-1.patch
Attached is a patch which wraps the cast in an instanceof thereby avoiding a possible cast class exception.
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3344) o.a.h.mapreduce.Reducer since
0.21 blindly casts to ReduceContext.ValueIterator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145772#comment-13145772 ]
Hudson commented on MAPREDUCE-3344:
-----------------------------------
Integrated in Hadoop-Common-0.23-Commit #152 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/152/])
Merge -r 1198909:1198910 from trunk to branch-0.23. Fixes: MAPREDUCE-3344.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1198914
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Reducer.java
> o.a.h.mapreduce.Reducer since 0.21 blindly casts to ReduceContext.ValueIterator
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3344
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3344
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.23.1
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: 0.24.0, 0.23.1
>
> Attachments: MAPREDUCE-3344-1.patch
>
>
> 0.21 mapreduce.Reducer introduced a blind cast to ReduceContext.ValueIterator. There should an instanceof check around this block to ensure we don't throw a CastClassException:
> {code}
> // If a back up store is used, reset it
> ((ReduceContext.ValueIterator)
> (context.getValues().iterator())).resetBackupStore();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira