You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/11 01:53:32 UTC
[GitHub] [pulsar] coderzc opened a new pull request, #16513: [fix][client] Make DeadLetterPolicy deserializable
coderzc opened a new pull request, #16513:
URL: https://github.com/apache/pulsar/pull/16513
Fixes #16487
### Motivation
DeadLetterPolicy can't deserialization, the root cause is DeadLetterPolicy without a No-argument constructor.
### Modifications
Add `@NoArgsConstructor` and `@AllArgsConstructor` annotates for DeadLetterPolicy.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as `testDeadLetterPolicyDeserialize`.
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #16513: [fix][client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#discussion_r917720648
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java:
##########
@@ -794,4 +795,16 @@ public void testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers() throws
otherConsumer.close();
consumer.close();
}
+
+ @Test
+ public void testDeadLetterPolicyDeserialize() throws Exception {
+ ConsumerBuilder<String> consumerBuilder = pulsarClient.newConsumer(Schema.STRING);
+ DeadLetterPolicy policy =
+ DeadLetterPolicy.builder().deadLetterTopic("a").retryLetterTopic("a").initialSubscriptionName("a")
+ .maxRedeliverCount(1).build();
+ consumerBuilder.deadLetterPolicy(policy);
+ Map<String, Object> config = new HashMap<>();
+ consumerBuilder.loadConf(config);
Review Comment:
Do you want to add `policy` in the config map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #16513: [fix][client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
coderzc commented on code in PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#discussion_r917763080
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java:
##########
@@ -794,4 +795,16 @@ public void testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers() throws
otherConsumer.close();
consumer.close();
}
+
+ @Test
+ public void testDeadLetterPolicyDeserialize() throws Exception {
+ ConsumerBuilder<String> consumerBuilder = pulsarClient.newConsumer(Schema.STRING);
+ DeadLetterPolicy policy =
+ DeadLetterPolicy.builder().deadLetterTopic("a").retryLetterTopic("a").initialSubscriptionName("a")
+ .maxRedeliverCount(1).build();
+ consumerBuilder.deadLetterPolicy(policy);
Review Comment:
I want test DeadLetterPolicy deserialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #16513: [fix][client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#discussion_r918661404
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java:
##########
@@ -794,4 +795,16 @@ public void testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers() throws
otherConsumer.close();
consumer.close();
}
+
+ @Test
+ public void testDeadLetterPolicyDeserialize() throws Exception {
+ ConsumerBuilder<String> consumerBuilder = pulsarClient.newConsumer(Schema.STRING);
+ DeadLetterPolicy policy =
+ DeadLetterPolicy.builder().deadLetterTopic("a").retryLetterTopic("a").initialSubscriptionName("a")
+ .maxRedeliverCount(1).build();
+ consumerBuilder.deadLetterPolicy(policy);
Review Comment:
Maybe you need to add the `DeadLetterPolicy` in the config map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #16513: [fix][client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#discussion_r917721066
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java:
##########
@@ -794,4 +795,16 @@ public void testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers() throws
otherConsumer.close();
consumer.close();
}
+
+ @Test
+ public void testDeadLetterPolicyDeserialize() throws Exception {
+ ConsumerBuilder<String> consumerBuilder = pulsarClient.newConsumer(Schema.STRING);
+ DeadLetterPolicy policy =
+ DeadLetterPolicy.builder().deadLetterTopic("a").retryLetterTopic("a").initialSubscriptionName("a")
+ .maxRedeliverCount(1).build();
+ consumerBuilder.deadLetterPolicy(policy);
Review Comment:
Do you want to add policy in the config map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #16513: [fix][client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#discussion_r918665749
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java:
##########
@@ -794,4 +795,16 @@ public void testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers() throws
otherConsumer.close();
consumer.close();
}
+
+ @Test
+ public void testDeadLetterPolicyDeserialize() throws Exception {
+ ConsumerBuilder<String> consumerBuilder = pulsarClient.newConsumer(Schema.STRING);
+ DeadLetterPolicy policy =
+ DeadLetterPolicy.builder().deadLetterTopic("a").retryLetterTopic("a").initialSubscriptionName("a")
+ .maxRedeliverCount(1).build();
+ consumerBuilder.deadLetterPolicy(policy);
Review Comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #16513: [fix][java-client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#issuecomment-1183993650
Thanks @coderzc!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #16513: [fix][java-client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #16513:
URL: https://github.com/apache/pulsar/pull/16513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #16513: [fix][client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#issuecomment-1180000928
Why not only add `@NoArgsConstructor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #16513: [fix][client] Make DeadLetterPolicy deserializable
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #16513:
URL: https://github.com/apache/pulsar/pull/16513#issuecomment-1180129665
> Why not only add `@NoArgsConstructor`?
Because `@Builder` needs `@AllArgsConstructor` if add `@NoArgsConstructor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org