You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/30 03:32:08 UTC
Review Request 26160: Fixing consumption double counting in quota
checks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26160/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-768
https://issues.apache.org/jira/browse/AURORA-768
Repository: aurora
Description
-------
Accounting for both initial and desired states when filtering out non updating tasks.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java a0da417623ac6c3c592fe22cc7c897d74151bfe1
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f961494adafce0e815175f59a7dd4037bec52559
Diff: https://reviews.apache.org/r/26160/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26160: Fixing consumption double counting in quota
checks.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 30, 2014, 3:07 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 249
> > <https://reviews.apache.org/r/26160/diff/1/?file=708987#file708987line249>
> >
> > method name is no longer correct
Updated.
> On Sept. 30, 2014, 3:07 a.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java, line 377
> > <https://reviews.apache.org/r/26160/diff/1/?file=708989#file708989line377>
> >
> > can you rephrease this in terms of what it _does_ rather than does _not_ do?
> >
> > ditto for the test case below
Rephrased.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26160/#review54945
-----------------------------------------------------------
On Sept. 30, 2014, 1:32 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26160/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 1:32 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-768
> https://issues.apache.org/jira/browse/AURORA-768
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Accounting for both initial and desired states when filtering out non updating tasks.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java a0da417623ac6c3c592fe22cc7c897d74151bfe1
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f961494adafce0e815175f59a7dd4037bec52559
>
> Diff: https://reviews.apache.org/r/26160/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26160: Fixing consumption double counting in quota
checks.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26160/#review54945
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
<https://reviews.apache.org/r/26160/#comment95268>
method name is no longer correct
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java
<https://reviews.apache.org/r/26160/#comment95267>
can you rephrease this in terms of what it _does_ rather than does _not_ do?
ditto for the test case below
- Bill Farner
On Sept. 30, 2014, 1:32 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26160/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 1:32 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-768
> https://issues.apache.org/jira/browse/AURORA-768
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Accounting for both initial and desired states when filtering out non updating tasks.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java a0da417623ac6c3c592fe22cc7c897d74151bfe1
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f961494adafce0e815175f59a7dd4037bec52559
>
> Diff: https://reviews.apache.org/r/26160/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26160: Fixing consumption double counting in quota
checks.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26160/
-----------------------------------------------------------
(Updated Sept. 30, 2014, 5:23 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-768
https://issues.apache.org/jira/browse/AURORA-768
Repository: aurora
Description
-------
Accounting for both initial and desired states when filtering out non updating tasks.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java a0da417623ac6c3c592fe22cc7c897d74151bfe1
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f961494adafce0e815175f59a7dd4037bec52559
Diff: https://reviews.apache.org/r/26160/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko