You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@libcloud.apache.org by briancurtin <gi...@git.apache.org> on 2013/10/25 06:44:43 UTC

[dev] libcloud pull request: Import LockTimeout before trying to catch it.

GitHub user briancurtin opened a pull request:

    https://github.com/apache/libcloud/pull/166

    Import LockTimeout before trying to catch it.

    If `lock.acquire` raised any sort of exception, a `NameError` would trump it because the `__enter__` method was trying to catch `lockfile.LockTimeout`, which wasn't imported.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/briancurtin/libcloud LockTimeout_import

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/166.patch

----
commit ad4f70bd97b244f3555ae2bdf05174ded2677a94
Author: briancurtin <br...@rackspace.com>
Date:   2013-10-25T04:39:16Z

    Import LockTimeout before trying to catch it.
    
    If lock.acquire raised any sort of exception, a NameError would
    trump it because the __enter__ method was trying to catch
    lockfile.LockTimeout, which wasn't imported.

----