You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2024/08/21 13:07:39 UTC

[PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

dajac opened a new pull request, #16945:
URL: https://github.com/apache/kafka/pull/16945

   This patch makes the new group coordinator, introduced as part of KIP-848, the default. This means that any KRaft cluster created from trunk default to using the new group coordinator. This includes all the integration tests which do not specify it. This patch also changes the default in system tests.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16945:
URL: https://github.com/apache/kafka/pull/16945#issuecomment-2302023026

   I have triggered a run of the system tests too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726467923


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -71,7 +71,7 @@ public class GroupCoordinatorConfig {
     /** New group coordinator configs */
     public static final String NEW_GROUP_COORDINATOR_ENABLE_CONFIG = "group.coordinator.new.enable";
     public static final String NEW_GROUP_COORDINATOR_ENABLE_DOC = "Enable the new group coordinator.";
-    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = false;
+    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = true;

Review Comment:
   We don't plan to let users choose the coordinator. Our plan is to make the new coordinator the default and only option starting from Apache Kafka 4.0. We will keep the internal config during for a few minor releases (as a safety net) but we will eventually remove it together with all the code of the old coordinator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16945:
URL: https://github.com/apache/kafka/pull/16945#issuecomment-2302022489

   @jeffkbkim @chia7712 Here is the next PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16945:
URL: https://github.com/apache/kafka/pull/16945#issuecomment-2306990548

   The [system tests](https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-08-22--001/report.html) looks good. There were only two failures of `kafkatest.tests.core.kraft_upgrade_test` that I had to fix with the last commit. The issue was that always using the new group coordinator in kraft mode does not work for old versions. We only want to use it in 4.0 (dev for now).
   
   I will simplify all this logic in the system tests separately. First, I need to bring back the `group.version` and change the default rebalance protocols config to include `consumer`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1730762901


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -71,7 +71,7 @@ public class GroupCoordinatorConfig {
     /** New group coordinator configs */
     public static final String NEW_GROUP_COORDINATOR_ENABLE_CONFIG = "group.coordinator.new.enable";
     public static final String NEW_GROUP_COORDINATOR_ENABLE_DOC = "Enable the new group coordinator.";
-    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = false;
+    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = true;

Review Comment:
   sounds good. Let ship it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726460735


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -577,23 +578,22 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _])
       if (processRoles.isEmpty) {
         throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported in KRaft cluster.")
       }
-      warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is enabled along with the new group coordinator. " +
-        "This is part of the preview of KIP-848 and MUST NOT be used in production.")
+      if (!isNewGroupCoordinatorEnabled) {
+        throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported by the new group coordinator.")
+      }
     }
     if (protocols.contains(GroupType.SHARE)) {
-      // The CONSUMER protocol enables the new group coordinator, and that's a prerequisite for share groups.
-      if (!protocols.contains(GroupType.CONSUMER)) {
-        throw new ConfigException(s"Enabling the new '${GroupType.SHARE}' rebalance protocol requires '${GroupType.CONSUMER}' to be enabled also.")
+      if (processRoles.isEmpty) {

Review Comment:
   This is a good question. For the context, `classic,consumer` will be the default value in 4.0. This means that controllers will also get this setting. If we restrict to the broker role, the controllers will fail to start. This is why I used this check to basically verify that we are in kraft mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726465180


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -577,23 +578,22 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _])
       if (processRoles.isEmpty) {
         throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported in KRaft cluster.")
       }
-      warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is enabled along with the new group coordinator. " +
-        "This is part of the preview of KIP-848 and MUST NOT be used in production.")
+      if (!isNewGroupCoordinatorEnabled) {
+        throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported by the new group coordinator.")
+      }
     }
     if (protocols.contains(GroupType.SHARE)) {
-      // The CONSUMER protocol enables the new group coordinator, and that's a prerequisite for share groups.
-      if (!protocols.contains(GroupType.CONSUMER)) {
-        throw new ConfigException(s"Enabling the new '${GroupType.SHARE}' rebalance protocol requires '${GroupType.CONSUMER}' to be enabled also.")
+      if (processRoles.isEmpty) {

Review Comment:
   > For the context, classic,consumer will be the default value in 4.0. This means that controllers will also get this setting. 
   
   fair enough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1725241272


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -577,23 +577,17 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _])
       if (processRoles.isEmpty) {
         throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported in KRaft cluster.")
       }
-      warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is enabled along with the new group coordinator. " +
-        "This is part of the preview of KIP-848 and MUST NOT be used in production.")
     }
     if (protocols.contains(GroupType.SHARE)) {
-      // The CONSUMER protocol enables the new group coordinator, and that's a prerequisite for share groups.
-      if (!protocols.contains(GroupType.CONSUMER)) {

Review Comment:
   That's fair. Let me add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726429138


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -71,7 +71,7 @@ public class GroupCoordinatorConfig {
     /** New group coordinator configs */
     public static final String NEW_GROUP_COORDINATOR_ENABLE_CONFIG = "group.coordinator.new.enable";
     public static final String NEW_GROUP_COORDINATOR_ENABLE_DOC = "Enable the new group coordinator.";
-    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = false;
+    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = true;

Review Comment:
   It is enabled by default now, so should we mark `group.coordinator.new.enable` as public config?



##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -577,23 +578,22 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _])
       if (processRoles.isEmpty) {
         throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported in KRaft cluster.")
       }
-      warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is enabled along with the new group coordinator. " +
-        "This is part of the preview of KIP-848 and MUST NOT be used in production.")
+      if (!isNewGroupCoordinatorEnabled) {
+        throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported by the new group coordinator.")
+      }
     }
     if (protocols.contains(GroupType.SHARE)) {
-      // The CONSUMER protocol enables the new group coordinator, and that's a prerequisite for share groups.
-      if (!protocols.contains(GroupType.CONSUMER)) {
-        throw new ConfigException(s"Enabling the new '${GroupType.SHARE}' rebalance protocol requires '${GroupType.CONSUMER}' to be enabled also.")
+      if (processRoles.isEmpty) {

Review Comment:
   Should we check the existence of `ProcessRole.BrokerRole` explicitly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726475602


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -71,7 +71,7 @@ public class GroupCoordinatorConfig {
     /** New group coordinator configs */
     public static final String NEW_GROUP_COORDINATOR_ENABLE_CONFIG = "group.coordinator.new.enable";
     public static final String NEW_GROUP_COORDINATOR_ENABLE_DOC = "Enable the new group coordinator.";
-    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = false;
+    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = true;

Review Comment:
   > will eventually remove it together with all the code of the old coordinator.
   
   happy to know it :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16945:
URL: https://github.com/apache/kafka/pull/16945#issuecomment-2304056651

   I have triggered a run of the system tests with the latest changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726565209


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##########
@@ -63,6 +63,11 @@
  */
 public interface GroupCoordinator {
 
+    /**
+     * @return True if the new coordinator; False otherwise.
+     */
+    boolean isNewGroupCoordinator();

Review Comment:
   I introduced this new method to the GroupCoordinator interface and I use it at runtime (e.g. in KafkaApi) to determine whether the new or the old coordinator is used. I did not in order to not rely on the `group.coordinator.new.enable` configuration at runtime. The issue was that in ZK mode, the `group.coordinator.new.enable` is also true by default now but the configuration is just ignored when the zk broker starts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1725217210


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -577,23 +577,17 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _])
       if (processRoles.isEmpty) {
         throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported in KRaft cluster.")
       }
-      warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is enabled along with the new group coordinator. " +
-        "This is part of the preview of KIP-848 and MUST NOT be used in production.")
     }
     if (protocols.contains(GroupType.SHARE)) {
-      // The CONSUMER protocol enables the new group coordinator, and that's a prerequisite for share groups.
-      if (!protocols.contains(GroupType.CONSUMER)) {

Review Comment:
   This line now should check whether the new GC is enabled. By default, that will be. If someone turns it off, they can't have share groups either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1729241006


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -71,7 +71,7 @@ public class GroupCoordinatorConfig {
     /** New group coordinator configs */
     public static final String NEW_GROUP_COORDINATOR_ENABLE_CONFIG = "group.coordinator.new.enable";
     public static final String NEW_GROUP_COORDINATOR_ENABLE_DOC = "Enable the new group coordinator.";
-    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = false;
+    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = true;

Review Comment:
   the default value is changed to `true`, so we need to set it to `false` explicitly when the tests want to test "old" coordinator.  Could you please update the following condition?
   
   https://github.com/apache/kafka/blob/be3e674e78092be7e1e5f3fae35d45f12639104c/core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala#L74
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726567807


##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -280,7 +280,8 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI
         self.configured_for_zk_migration = False
         
         # Set use_new_coordinator based on context and arguments.
-        default_use_new_coordinator = False
+        # The new group coordinator is used by default in kraft mode.
+        default_use_new_coordinator = self.quorum_info.using_kraft

Review Comment:
   We can only use it in kraft mode. The issue is that we have logic in some tests which adds `consumer` to the enabled rebalance protocols when the new coordinator is enabled. This fails in zk mode because `consumer` is not supported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16945:
URL: https://github.com/apache/kafka/pull/16945#issuecomment-2304809923

   Fixed on last test. Otherwise, tests look good now. I wait on the system tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16945:
URL: https://github.com/apache/kafka/pull/16945#issuecomment-2306990861

   @chia7712 Could you please review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1730706726


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -71,7 +71,7 @@ public class GroupCoordinatorConfig {
     /** New group coordinator configs */
     public static final String NEW_GROUP_COORDINATOR_ENABLE_CONFIG = "group.coordinator.new.enable";
     public static final String NEW_GROUP_COORDINATOR_ENABLE_DOC = "Enable the new group coordinator.";
-    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = false;
+    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = true;

Review Comment:
   I will remove all the `kraft+kip848` and that condition in a subsequent PR. We really want all the existing tests to use the new coordinator now. If someone wants to use the old coordinator for some tests, he will have to explicitly set the configuration to disable it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #16945:
URL: https://github.com/apache/kafka/pull/16945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-14048; [2/N] Use the new group coordinator by default in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16945:
URL: https://github.com/apache/kafka/pull/16945#issuecomment-2303949722

   I have a few fixes for tests coming soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org