You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/11 06:34:20 UTC

[GitHub] [apisix-website] Baoyuantop opened a new pull request #444: style: unmount Contributor200Poster component

Baoyuantop opened a new pull request #444:
URL: https://github.com/apache/apisix-website/pull/444


   Fixes: #443 
   
   Changes:
   
   Unmount `Contributor200Poster` component.
   
   Screenshots of the change:
   
   ![image](https://user-images.githubusercontent.com/30611190/128980801-481e110a-11c2-45e6-b822-234f024d0234.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #444:
URL: https://github.com/apache/apisix-website/pull/444#issuecomment-896541029


   ✔️ Deploy Preview for *apisix* ready!
   
   
   🔨 Explore the source changes: 582db4e2acf8f3f12c2a62df3a256bf080a2e836
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/61136f647f61e0000764ca0a](https://app.netlify.com/sites/apisix/deploys/61136f647f61e0000764ca0a?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-444--apisix.netlify.app](https://deploy-preview-444--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] netlify[bot] commented on pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #444:
URL: https://github.com/apache/apisix-website/pull/444#issuecomment-896541029


   👷 Deploy Preview for *apisix* processing.
   
   
   🔨 Explore the source changes: 582db4e2acf8f3f12c2a62df3a256bf080a2e836
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/61136f647f61e0000764ca0a](https://app.netlify.com/sites/apisix/deploys/61136f647f61e0000764ca0a?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] 1502shivam-singh commented on pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #444:
URL: https://github.com/apache/apisix-website/pull/444#issuecomment-897969966


   Hey @Baoyuantop, how about you refactor that theme based poster selection code using the useThemeContext[1] hook. No issues with the code at present, just that this would make it more compact.
   
   [1] https://docusaurus.io/docs/api/themes/configuration#usethemecontext


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan merged pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #444:
URL: https://github.com/apache/apisix-website/pull/444


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] guoqqqi commented on pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #444:
URL: https://github.com/apache/apisix-website/pull/444#issuecomment-897517822


   wait for #447 update the Contributor200Poster link to this article
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Baoyuantop commented on pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #444:
URL: https://github.com/apache/apisix-website/pull/444#issuecomment-898102640


   > Hey @Baoyuantop, how about you refactor that theme based poster selection code using the useThemeContext[1] hook. No issues with the code at present, just that this would make it more compact.
   > 
   > [1] https://docusaurus.io/docs/api/themes/configuration#usethemecontext
   
   Very good suggestion, thanks, I will revise it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Baoyuantop commented on pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #444:
URL: https://github.com/apache/apisix-website/pull/444#issuecomment-896550133


   cc @guoqqqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Baoyuantop commented on pull request #444: style: unmount Contributor200Poster component

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #444:
URL: https://github.com/apache/apisix-website/pull/444#issuecomment-898159634


   I just changed the content of the card and it looks like this now:
   
   **light mode**
   
   ![image](https://user-images.githubusercontent.com/30611190/129300006-16674f32-5d0b-4e95-80be-3b710c3d46a7.png)
   
   **dark mode**
   
   ![image](https://user-images.githubusercontent.com/30611190/129300081-163e04f3-89d5-4bf4-aed9-7b75d7bf3857.png)
   
   Any good suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org