You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/09/04 15:49:59 UTC

[Bug 123181] New: Rhombus are reflected

https://issues.apache.org/ooo/show_bug.cgi?id=123181

            Bug ID: 123181
        Issue Type: DEFECT
           Summary: Rhombus are reflected
           Product: Draw
           Version: 4.0.0
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: open-import
          Assignee: issues@openoffice.apache.org
          Reporter: efa@iol.it
                CC: issues@openoffice.apache.org

I had an .odg file saved with OO3.x
Opening with OO4 get the rhombus reflected
This seems a regression

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |
           Severity|critical                    |major

--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: Indeed, can reproduce. Simple way:
- Start AOO400
- draw a rectangle (CustomShape, not regular)
- shear (e.g. 60)
- save, reload -> shear is at -60, object is 'flipped', keeping it's upper edge
but shearing to the opposite side.
- loads correctly in AOO341

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: CHecked and also made sure that in AOO341 the mirroring of fShearX in
SdrObjCustomShape::TRSetBaseGeometry was not there. The fix for #121932# here
was wrong, the trunk version does not correct the mirrored shear values,
neither at the object level, nor on the API or XML level. Taking back the
mirroring of the shear angle (maybe I was at aw080 in my thoughts here ;-( )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
ALG:@efa: Many thanks for finding and reporting this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

4.0.1_release_blocker requested: [Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
Armin Le Grand <Ar...@me.com> has asked  for 4.0.1_release_blocker:
Bug 123181: Rhombus are reflected
https://issues.apache.org/ooo/show_bug.cgi?id=123181


------- Additional Comments from Armin Le Grand <Ar...@me.com>
ALG: Comitted fix for trunk, set regression flag for AOO401, done for AOO410

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsc@apache.org
              Flags|4.0.1_release_blocker?      |4.0.1_release_blocker+

--- Comment #12 from jsc@apache.org ---
approve showstopper request

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

--- Comment #11 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1520057 into trunk:
i123181 Corrected mirroring of shear angle in
SdrObjCustomShape::TRSetBaseGeo...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

4.0.1_release_blocker granted: [Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
jsc@apache.org has granted Armin Le Grand <Ar...@me.com>'s request for
4.0.1_release_blocker:
Bug 123181: Rhombus are reflected
https://issues.apache.org/ooo/show_bug.cgi?id=123181


------- Additional Comments from jsc@apache.org
approve showstopper request

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

--- Comment #14 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1521006 into branches/AOO401:
i123181 Corrected mirroring of shear angle in
SdrObjCustomShape::TRSetBaseGeo...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.1.0
              Flags|                            |4.0.1_release_blocker?

--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
ALG: Comitted fix for trunk, set regression flag for AOO401, done for AOO410

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |rb.henschel@t-online.de
     Ever confirmed|0                           |1
           Severity|major                       |critical

--- Comment #3 from Regina Henschel <rb...@t-online.de> ---
It is an import problem. You see the same error with a file created in AOO4.0.

Import is OK in r1453677, import fails in r1466899.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

--- Comment #2 from efa <ef...@iol.it> ---
Created attachment 81450
  --> https://issues.apache.org/ooo/attachment.cgi?id=81450&action=edit
export of OO3.x rendering of the same file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Adding regression keyword

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

--- Comment #1 from efa <ef...@iol.it> ---
Created attachment 81449
  --> https://issues.apache.org/ooo/attachment.cgi?id=81449&action=edit
.odg file correctly seen with OO3.x

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
ALG: Thanks, Regina! Looks as if we looked at the same time ;-)
Definitely has to do with TRGetBaseGeometry/TRSetBaseGeometry and how it
handles shear; in SdrTextObj it is *not* converted/mirrored at all, in
SdrObjCustomShape it is mirrored in TRSetBaseGeometry (this seems to be the
error, #121932# is involved). To make sure I will have to check what the API
and the ODF im/export uses...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com

--- Comment #4 from Regina Henschel <rb...@t-online.de> ---
Hi Armin, r1465696 looks suspicious.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123181] Rhombus are reflected

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123181

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.0                       |4.0.1

--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked with AOO401 branch and comitted, done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.