Re: [PR] [CELEBORN-1968] Publish metric for unreleased partition location count when worker was gracefully shutdown [celeborn]

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #3213:
URL: https://github.com/apache/celeborn/pull/3213#discussion_r2079378303


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -453,6 +453,14 @@ private[celeborn] class Worker(
       0
     }
   }
+  // Unreleased partition location count when worker is restarting
+  workerSource.addGauge(WorkerSource.UNRELEASED_PARTITION_LOCATION_COUNT) { () =>
+    if (shutdown.get()) {
+      partitionLocationInfo.primaryPartitionLocations.values()

Review Comment:
    should be `primaryPartitionLocations.values().size() + replicaPartitionLocations.values().size()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org