[GitHub] [incubator-iceberg] rdsr opened a new pull request #703: StructType#indexFields() breaks when schema contains column names which differ only by case

[GitBox <gi...@apache.org>]

rdsr opened a new pull request #703: StructType#indexFields() breaks when schema contains column names which differ only by case
URL: https://github.com/apache/incubator-iceberg/pull/703
 
 
   We have a few datasets having columns which differ by case only.  When updating existing Iceberg tables schema, we use `reassignIds` which breaks when building the `fieldsByLowerCaseName` map.  We see the following exception
   
   ```
   at com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:214)
           at com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:208)
           at com.google.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:146)
           at com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:109)
           at com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:392)
           at org.apache.iceberg.types.Types$StructType.indexFields(Types.java:643)
           at org.apache.iceberg.types.Types$StructType.lazyFieldsByName(Types.java:614)
           at org.apache.iceberg.types.Types$StructType.field(Types.java:547)
           at org.apache.iceberg.types.ReassignIds.field(ReassignIds.java:89)
           at org.apache.iceberg.types.ReassignIds.field(ReassignIds.java:29)
   ```
   
   I think this map is only used to support case-insensitive access. As long as we don't use that feature for these tables I think it should be ok to make this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org