You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by sihuazhou <gi...@git.apache.org> on 2018/05/23 13:52:35 UTC

[GitHub] flink pull request #6063: [FLINK-9426][test] Harden RocksDBWriteBatchPerform...

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/6063

    [FLINK-9426][test] Harden RocksDBWriteBatchPerformanceTest.benchMark()

    ## What is the purpose of the change
    
    We use the assert to check the performance of WriteBatch is better than Put(), this should be true in general, but in sometimes this could also be false. We may need to follow the other tests under the `org.apache.flink.contrib.streaming.state.benchmark.*`, only use the timeout property to guard the tests.
    
    ## Brief change log
    
      - remove asserts from RocksDBWriteBatchPerformanceTest.benchMark()
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink FLINK-9426

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6063.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6063
    
----
commit 167289827e75a150689abed84784b2c5685b9ed0
Author: sihuazhou <su...@...>
Date:   2018-05-23T13:47:41Z

    remove asserts from RocksDBWriteBatchPerformanceTest.benchMark()

----


---

[GitHub] flink issue #6063: [FLINK-9426][test] Harden RocksDBWriteBatchPerformanceTes...

Posted by sihuazhou <gi...@git.apache.org>.

Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/6063
  
    cc @StefanRRichter I'm sorry for introduce this unstable tests...


---

[GitHub] flink pull request #6063: [FLINK-9426][test] Harden RocksDBWriteBatchPerform...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6063


---

[GitHub] flink issue #6063: [FLINK-9426][test] Harden RocksDBWriteBatchPerformanceTes...

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/6063
  
    @sihuazhou no problem, I will merge this fixup.


---