You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/04/12 22:44:08 UTC

[GitHub] [incubator-openwhisk] rdiaz82 opened a new pull request #4445: Adding Rust 1.34 action loop support

rdiaz82 opened a new pull request #4445: Adding Rust 1.34 action loop support 
URL: https://github.com/apache/incubator-openwhisk/pull/4445
 
 
   <!--- Title: Add rust:1.34 runtime support to default deployments -->
   
   ## Description
   The included changes in this PR are the following:
   1.  Add rust:1.34 to core ansible/vagrant deploy
     - [X] Add rust:1.34entry into ansible/files/runtimes.json
     - [X] Add rust-actions.md link in docs/actions.md
     - [ ] Implement rust-actions.md documentation
     - [X] Update unicode tests https://github.com/apache/incubator-openwhisk/tree/master/tests/dat/actions/unicode.tests
     - [X] Update swagger file https://github.com/apache/incubator-openwhisk/blob/master/core/controller/src/main/resources/apiv1swagger.json
   2. Add rust:1.34 to docker-compose deploy
     - [ ]  Add rust:1.34 into runtime manifest
   https://github.com/apache/incubator-openwhisk-devtools/blob/master/docker-compose/docker-whisk-controller.env#L64
   3. Add rust:1.34 to deploy-kube
    -  [ ] Add rust:1.34 into runtime manifest
   https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/helm/openwhisk/runtimes.json
   4. Update wskdeploy with rust:1.34
   - [ ] Update spec, and tests for rust:1.34
   - [ ] https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/runtimes/runtimes.go#L267
   - [ ] https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/specification/html/spec_actions.md#valid-runtime-names
   - [ ] https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/tests/src/integration/runtimetests/manifest.yaml#L5
   5. Update website with rust:1.34
   - [ ] Update js action section with rust:1.34
   - [ ] https://github.com/apache/incubator-openwhisk-website/blob/master/_layouts/documentation.html
   - [ ] https://github.com/apache/incubator-openwhisk-website/tree/master/_includes/code
   
   ## Related issue and scope
   https://github.com/apache/incubator-openwhisk/issues/4443
   
   ## My changes affect the following components
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [X] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [X] Documentation
   
   ## Types of changes
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [X] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [X] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [X] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services