You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "G-XD (via GitHub)" <gi...@apache.org> on 2023/11/03 13:24:47 UTC

[PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

G-XD opened a new pull request, #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "Zheaoli (via GitHub)" <gi...@apache.org>.
Zheaoli commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1799256494

   https://github.com/apache/incubator-opendal/pull/3514
   
   Will fixed this. Already test it in local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "Zheaoli (via GitHub)" <gi...@apache.org>.
Zheaoli commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1799038416

   > The test for the python binding has failed, could you please take a look? cc @Xuanwo @Zheaoli 
   
   Maybe you can use the tmpfs like /tmp/data.persky


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "Zheaoli (via GitHub)" <gi...@apache.org>.
Zheaoli commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1799187527

   > Seems python will execute tests concurrently, we should fix it too.
   
   No, it's not related to any concurrent problem.
   
   Just because of the operator initial twice. I will fix this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1798028443

   > I've tried to migrate these services with local files as resources before and it always seems to fail due to nextest.
   
   I'd like to continue using the same testing tool for developers. How about we just use `cargo test` to run behavior tests instead of `cargo nextest`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1798161344

   Let's rebase and continue this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1799125079

   Seems python will execute tests concurrently, we should fix it too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1795155479

   I've tried to migrate these services with local files as resources before and it always seems to fail due to nextest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1798163639

   https://github.com/apache/incubator-opendal/pull/3505 has been merged, let's use `RUST_TEST_THREADS=1` to make sure only one test running.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "G-XD (via GitHub)" <gi...@apache.org>.
G-XD commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1795188032

   > I've tried to migrate these services with local files as resources before and it always seems to fail due to nextest.
   
   Yes, using cargo test will work, but using nextest will fail. 😟


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(services/persy): migrate tot test planner [incubator-opendal]

Posted by "G-XD (via GitHub)" <gi...@apache.org>.
G-XD commented on PR #3476:
URL: https://github.com/apache/incubator-opendal/pull/3476#issuecomment-1798813940

   The test for the python binding has failed, could you please take a look? cc @Xuanwo @Zheaoli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org