You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Reser <be...@reser.org> on 2003/12/24 04:15:25 UTC
[PATCH] Load .so.0 not .so
This is currently creating an icky problem for me on Mandrake 9.2 and
newer. .so files that are symlinks are considered development files and
automatically cause the package to provide devel(libfoo-MAJOR) and
automatically require a similar dependency on every library that they
depend upon.
If we use the library naming that APR is using (see the Library Naming
section of http://apr.apache.org/versioning.html) then the first integer
after the .so will always be 0. Given that we're currently naming libs:
libsvn_foo-1.so.0.0.0 it seems that we are indeed following this
convention.
If this could be applied to the 1.0-stabilization it would be make a
very happy camper.
[[[
.so symlinks should only be development files amd shouldn't be required
at runtime. Assuming we follow APR library versioning conventions we be
loading .so.0 instead of .so.
* subversion/libsvn_ra/ra_loader.c
(load_ra_module): Try to load libsvn_ra_foo-MAJOR.so.0
instead of libsvn_ra_foo-MAJOR.so
]]]
Index: subversion/libsvn_ra/ra_loader.c
===================================================================
--- subversion/libsvn_ra/ra_loader.c (revision 8075)
+++ subversion/libsvn_ra/ra_loader.c (working copy)
@@ -97,7 +97,7 @@
apr_status_t status;
/* ### fix the .so part */
- libname = apr_psprintf (pool, "libsvn_ra_%s-%d.so",
+ libname = apr_psprintf (pool, "libsvn_ra_%s-%d.so.0",
ra_name, SVN_VER_LIBRARY);
funcname = apr_psprintf (pool, "svn_ra_%s_init", ra_name);
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Load .so.0 not .so
Posted by Ben Reser <be...@reser.org>.
On Wed, Dec 24, 2003 at 08:08:35AM -0500, Francois Beausoleil wrote:
> Just a few notes about your log message:
Yeah I noticed the typos after I'd sent it. :(
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Load .so.0 not .so
Posted by Francois Beausoleil <fb...@users.sourceforge.net>.
Just a few notes about your log message:
On Tue, 23 Dec 2003 20:15:25 -0800, "Ben Reser" <be...@reser.org> said:
[snip]
>
> [[[
> .so symlinks should only be development files amd shouldn't be required
/amd/asd/
> at runtime. Assuming we follow APR library versioning conventions we be
/we be/we should be/
> loading .so.0 instead of .so.
>
> * subversion/libsvn_ra/ra_loader.c
> (load_ra_module): Try to load libsvn_ra_foo-MAJOR.so.0
> instead of libsvn_ra_foo-MAJOR.so
> ]]]
>
[snip]
Have a nice day !
François
Developer of Java Gui Builder
http://jgb.sourceforge.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Load .so.0 not .so
Posted by Greg Hudson <gh...@MIT.EDU>.
I discussed this with Ben on IRC before he submitted the patch, and it
seems right to me. So, I will commit it and put it up as a 1.0
candidate in the next day or so if no one objects.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org