[jira] [Commented] (TEZ-2248) VertexImpl/DAGImpl.checkForCompletion have too many termination cause checks

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506534#comment-14506534 ] 

TezQA commented on TEZ-2248:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12727132/TEZ-2248-1.patch
  against master revision ec45c51.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/511//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/511//console

This message is automatically generated.

> VertexImpl/DAGImpl.checkForCompletion have too many termination cause checks
> ----------------------------------------------------------------------------
>
>                 Key: TEZ-2248
>                 URL: https://issues.apache.org/jira/browse/TEZ-2248
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2248-1.patch
>
>
> There is an if check for each termination cause which makes code long and we need to handle each new termination cause with more code. This could be abstracted into a method that gets termination cause string based on the enum and make this method shorter and stable. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)