You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ericl <gi...@git.apache.org> on 2018/03/04 07:58:24 UTC
[GitHub] spark pull request #20730: [SQL] [minor] XPathDouble prettyPrint should say ...
GitHub user ericl opened a pull request:
https://github.com/apache/spark/pull/20730
[SQL] [minor] XPathDouble prettyPrint should say 'double' not 'float'
## What changes were proposed in this pull request?
It looks like this was incorrectly copied from `XPathFloat` in the class above.
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericl/spark fix-typo-xpath
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20730.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20730
----
commit c2f23350750019e49525eb5c133a9472cee0d08d
Author: Eric Liang <ek...@...>
Date: 2018-03-04T07:55:47Z
s/float/double
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20730: [SQL] [minor] XPathDouble prettyPrint should say 'double...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20730
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20730: [SQL] [minor] XPathDouble prettyPrint should say ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20730
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20730: [SQL] [minor] XPathDouble prettyPrint should say 'double...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20730
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20730: [SQL] [minor] XPathDouble prettyPrint should say 'double...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20730
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87943/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20730: [SQL] [minor] XPathDouble prettyPrint should say 'double...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20730
**[Test build #87943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87943/testReport)** for PR 20730 at commit [`c2f2335`](https://github.com/apache/spark/commit/c2f23350750019e49525eb5c133a9472cee0d08d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20730: [SQL] [minor] XPathDouble prettyPrint should say 'double...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20730
**[Test build #87943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87943/testReport)** for PR 20730 at commit [`c2f2335`](https://github.com/apache/spark/commit/c2f23350750019e49525eb5c133a9472cee0d08d).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20730: [SQL] [minor] XPathDouble prettyPrint should say 'double...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20730
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1263/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20730: [SQL] [minor] XPathDouble prettyPrint should say 'double...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20730
Merged to master and branch-2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org