You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/07/24 02:20:45 UTC
Review Request 36754: Updated Isolator::prepare to return
IsolatorPrepareInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36754/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-3133
https://issues.apache.org/jira/browse/MESOS-3133
Repository: mesos
Description
-------
IsolatorPrepareInfo contains CommandInfo as well as Environment. While
the CommandInfo lists the commands to be run inside the containerized
context, the Environment allows the isolator to specify environment
variables for the Executor itself.
Diffs
-----
include/mesos/slave/isolator.hpp 85e38f5e4aa66527f1756fa259b93389f45028b3
include/mesos/slave/isolator.proto PRE-CREATION
src/slave/containerizer/isolator.cpp 278824c0cb662bb09150e8cb5a72dafef034e6fb
src/slave/containerizer/isolators/cgroups/cpushare.hpp 2118c97d4f3d2e58fab62c6e99d5bec6f4df8bbd
src/slave/containerizer/isolators/cgroups/cpushare.cpp 750bef947c11eb55236ac46109b9dd97e62b453d
src/slave/containerizer/isolators/cgroups/mem.hpp dc752014236b69d34c6b33a06fc00580780b0b4c
src/slave/containerizer/isolators/cgroups/mem.cpp b0e343fdc7088b2895d5dc8bb416dbcbf241cae5
src/slave/containerizer/isolators/cgroups/perf_event.hpp 560cd0359a2795a937335efa30dc380a60fcb540
src/slave/containerizer/isolators/cgroups/perf_event.cpp 512df3be7fdf6bac22ad4122f54a21d9986a1a6a
src/slave/containerizer/isolators/filesystem/posix.hpp 16ba26f4f5b515acbeb3c4d514d4eecf2f277df8
src/slave/containerizer/isolators/filesystem/posix.cpp 0c5662741a7562872f0dbfaf9c9b6d923d80af5d
src/slave/containerizer/isolators/filesystem/shared.hpp 4d7d9a9e310cb636dc4983de86e9e4c9321104ea
src/slave/containerizer/isolators/filesystem/shared.cpp 24f30746be7b5be95a4d8f442a3a5464d1f0f2a0
src/slave/containerizer/isolators/namespaces/pid.hpp 9cda3fd418d0f0df4d12ed1367da277b81866103
src/slave/containerizer/isolators/namespaces/pid.cpp 5de0791a835d725b7c7aae1ba585a94cff9372f1
src/slave/containerizer/isolators/network/port_mapping.hpp 6b5cf62838637e9759935f9edf0c152a035005fe
src/slave/containerizer/isolators/network/port_mapping.cpp a7757f2a51f04da27645074f048722c22a2be752
src/slave/containerizer/isolators/posix.hpp 271061ef97aea96bb816982e530c84554d4b08d8
src/slave/containerizer/isolators/posix/disk.hpp 5dfa815edaee9b17c19ae2a7491e63c545c8ab1f
src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd
src/slave/containerizer/mesos/containerizer.hpp f6c580d1b629ee799977cc8824f337764d893c5f
src/slave/containerizer/mesos/containerizer.cpp 609620c4322e41562597ee682b311cd320bca6d2
src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db
src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68
src/tests/isolator_tests.cpp 7ad0cb643f2add636dfbb4a01495c68b2f4dfdd4
Diff: https://reviews.apache.org/r/36754/diff/
Testing
-------
make check with an added test (in the followup review).
Thanks,
Kapil Arya
Re: Review Request 36754: Updated Isolator::prepare to return
ContainerPrepareInfo.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36754/
-----------------------------------------------------------
(Updated July 24, 2015, 6:05 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
renamed IsolatorPrepareInfo to ContainerPrepareInfo; rebased.
Summary (updated)
-----------------
Updated Isolator::prepare to return ContainerPrepareInfo.
Bugs: MESOS-3133
https://issues.apache.org/jira/browse/MESOS-3133
Repository: mesos
Description (updated)
-------
ContainerPrepareInfo contains CommandInfo as well as Environment. While
the CommandInfo lists the commands to be run inside the containerized
context, the Environment allows the isolator to specify environment
variables for the Executor itself.
Diffs (updated)
-----
include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987
include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549
src/slave/containerizer/isolator.hpp aa6f1e6838ba0f7ec7f300f740b2f5ee0529209b
src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072
src/slave/containerizer/isolators/cgroups/cpushare.hpp 409a3a997a7b2c7104421f48ee1078e8fd369a2a
src/slave/containerizer/isolators/cgroups/cpushare.cpp ccaf1e372c0693522aed2e0aa8d680e404faf8ef
src/slave/containerizer/isolators/cgroups/mem.hpp d43ba6d3debfc6279a023bd28f584635eeb79dc3
src/slave/containerizer/isolators/cgroups/mem.cpp 70c9868dbb670278b3bb4e4322598285488851fe
src/slave/containerizer/isolators/cgroups/perf_event.hpp 3796b30a56799a00f1ddbec9bd20b9203d689856
src/slave/containerizer/isolators/cgroups/perf_event.cpp a62a4e6ca573230af17781495eae63115ef28f00
src/slave/containerizer/isolators/filesystem/posix.hpp 2afc572d20acb3d31d3981d99ffe6ea45ae93dff
src/slave/containerizer/isolators/filesystem/posix.cpp 5e5a896d9888375259a38dcc68d03dce6406a28e
src/slave/containerizer/isolators/filesystem/shared.hpp f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936
src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc
src/slave/containerizer/isolators/namespaces/pid.hpp 61db386b1d6f602edcba8a1fa251cfd12a534aca
src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144
src/slave/containerizer/isolators/network/port_mapping.hpp fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac
src/slave/containerizer/isolators/network/port_mapping.cpp 3f35782c9e0e458169777bab778178c524a58b2b
src/slave/containerizer/isolators/posix.hpp 58d9911fef6f57dd078c533221094f9c69489fe4
src/slave/containerizer/isolators/posix/disk.hpp 86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a
src/slave/containerizer/isolators/posix/disk.cpp 845496c865a92946910a4e9dd50d05482503b7ef
src/slave/containerizer/mesos/containerizer.hpp 5155362bef9163af3fa5334be3a39b91549e1ec1
src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368
src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef
src/tests/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6
src/tests/isolator_tests.cpp 7ad0cb643f2add636dfbb4a01495c68b2f4dfdd4
Diff: https://reviews.apache.org/r/36754/diff/
Testing
-------
make check with an added test (in the followup review).
Thanks,
Kapil Arya