You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/15 15:19:58 UTC

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK

ThanoshanMV commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-761002682


   ![rollbackEPS](https://user-images.githubusercontent.com/48581379/104743545-d1571c00-5771-11eb-8614-c90d1240f6a7.png)
   In this ROLLBACK Backus-Naur Form Syntax:
   1. I considered keyword `WORK` as an Oracle Keyword. Is that okay or should we consider it as a Keyword?
   2. How can we substitute the placeholders `savepoint` and `string`? 
   
   Currently, I substituted `string` as `stringLiterals` imported from `BaseRule`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org