You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2012/02/28 07:24:56 UTC

DO NOT REPLY [Bug 52781] New: Content-Disposition header garbled even if browser compatible headers is checked (HC4)

https://issues.apache.org/bugzilla/show_bug.cgi?id=52781

             Bug #: 52781
           Summary: Content-Disposition header garbled even if browser
                    compatible headers is checked (HC4)
           Product: JMeter
           Version: 2.6
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HTTP
        AssignedTo: issues@jmeter.apache.org
        ReportedBy: takatsuru.tetsuya@nttcom.co.jp
    Classification: Unclassified


Some browsers (IE, FF, Opera, etc...) uses raw filename for "filename"
parameter of Content-Disposition header in the part of multipart post request.

for example:

-----(bounary)-----
Content-Disposition: form-data; name="uploadFile"; filename="私の添付ファイル.txt"
Content-Type: text/plain

... (content of file)
-----(bounary)-----

Now, the filename is changed to "????????.txt" regardless of "browser
compatible headers" option:

-----(bounary)-----
Content-Disposition: form-data; name="uploadFile"; filename="????????.txt"
Content-Type: text/plain

... (content of file)
-----(bounary)-----

However, HTTPHC4Impl is expected to send request the same as browsers when
"browser compatible mode" is checked.

Charset is needed for constructor of MultipartEntity so that browser compatible
mode works correctly.
Here is a patch fixing it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52781] Content-Disposition header garbled even if browser compatible headers is checked (HC4)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52781

--- Comment #1 from Tetsuya Takatsuru <ta...@nttcom.co.jp> 2012-02-28 06:27:44 UTC ---
Created attachment 28394
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28394
patch on HTTPHC4Impl

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52781] Content-Disposition header garbled even if browser compatible headers is checked (HC4)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52781

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|PC                          |All

--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> 2012-02-28 12:37:33 UTC ---
Thanks for patch and clear submission.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52781] Content-Disposition header garbled even if browser compatible headers is checked (HC4)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52781

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
         Resolution|                            |FIXED

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> 2012-02-28 12:06:55 UTC ---
Applied partly with fix when content encoding is empty or null.
Also fixed Test Case TestHTTPSamplersAgainstHttpMirrorServer that computed
wrong boundary


Date: Tue Feb 28 10:03:45 2012
New Revision: 1294541

URL: http://svn.apache.org/viewvc?rev=1294541&view=rev
Log:
Bug 52781 - Content-Disposition header garbled even if browser compatible
headers is checked (HC4)

Modified:
  
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java

Date: Tue Feb 28 12:03:41 2012
New Revision: 1294596

URL: http://svn.apache.org/viewvc?rev=1294596&view=rev
Log:
Bug 52781 - Content-Disposition header garbled even if browser compatible
headers is checked (HC4)
Handle correctly null contentEncoding

Modified:
  
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java


Date: Tue Feb 28 12:05:02 2012
New Revision: 1294598

URL: http://svn.apache.org/viewvc?rev=1294598&view=rev
Log:
Bug 52781 - Content-Disposition header garbled even if browser compatible
headers is checked (HC4)
Fixed wrong Boundary extraction

Modified:
  
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/TestHTTPSamplersAgainstHttpMirrorServer.java

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.