You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by sh...@inmobi.com on 2014/08/05 08:52:18 UTC
Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1950
https://issues.apache.org/jira/browse/OOZIE-1950
Repository: oozie-git
Description
-------
Adds filter on nominal time in get coord actions
Diffs
-----
client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
pom.xml be5e84a
src/main/resources/checkstyle.xml b75d737
Diff: https://reviews.apache.org/r/24299/diff/
Testing
-------
UTs
Thanks,
shwethags
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by sh...@inmobi.com.
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java, lines 126-127
> > <https://reviews.apache.org/r/24299/diff/1/?file=651741#file651741line126>
> >
> > To be removed
yes, will remove
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > client/src/main/java/org/apache/oozie/client/OozieClient.java, line 125
> > <https://reviews.apache.org/r/24299/diff/1/?file=651738#file651738line125>
> >
> > nominaltime or nominal_time - to be consistent with other filter params which don't use camel casing. I see that case does not matter later due to equalsIgnorecase check, but still just to keep naming consistent.
will rename
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java, line 827
> > <https://reviews.apache.org/r/24299/diff/1/?file=651742#file651742line827>
> >
> > unintended change? Needs to be reverted.
Is this intentional of not returning any actions by default? Even some user had questions on why its not returning any actions and then he had to set len
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java, line 89
> > <https://reviews.apache.org/r/24299/diff/1/?file=651744#file651744line89>
> >
> > Please remove this line
ok
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, line 43
> > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line43>
> >
> > default is 1000
Its 0 in V1JobServlet.java
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, line 45
> > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line45>
> >
> > Below changes can make the help a little more clear.
> >
> > - The comparators are not applicable for all keys. So need to clarify that =, != is applicable for status and =, !=, <, <=, >, >= applicable for nominaltime.
> > - Would be good to have an example.
> >
All comparators apply on all keys. = applies on nominal time to get single action. Just like in sql
Example is in later section of filter
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > src/main/resources/checkstyle.xml, line 31
> > <https://reviews.apache.org/r/24299/diff/1/?file=651747#file651747line31>
> >
> > Where is this property defined? Not able to find it in code base.
in main pom.xml. This helps to build each module separately
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review49880
-----------------------------------------------------------
On Aug. 5, 2014, 6:52 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:52 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
> pom.xml be5e84a
> src/main/resources/checkstyle.xml b75d737
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by sh...@inmobi.com.
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, line 45
> > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line45>
> >
> > Below changes can make the help a little more clear.
> >
> > - The comparators are not applicable for all keys. So need to clarify that =, != is applicable for status and =, !=, <, <=, >, >= applicable for nominaltime.
> > - Would be good to have an example.
> >
>
> shwethags wrote:
> All comparators apply on all keys. = applies on nominal time to get single action. Just like in sql
>
> Example is in later section of filter
>
> Rohini Palaniswamy wrote:
> For status, only = and != makes sense.
Yes, but with adding more keys in the filter, this will become complicated conditions. So, we can leave it as is?
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > src/main/resources/checkstyle.xml, line 31
> > <https://reviews.apache.org/r/24299/diff/1/?file=651747#file651747line31>
> >
> > Where is this property defined? Not able to find it in code base.
>
> shwethags wrote:
> in main pom.xml. This helps to build each module separately
>
> Rohini Palaniswamy wrote:
> The main pom.xml does not have checkstyle.header.file defined currently. I did search *.xml file in codebase.
The change in pom.xml:
<headerLocation>src/main/resources/checkstyle-header.txt</headerLocation>
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review49880
-----------------------------------------------------------
On Aug. 5, 2014, 6:52 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:52 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
> pom.xml be5e84a
> src/main/resources/checkstyle.xml b75d737
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > src/main/resources/checkstyle.xml, line 31
> > <https://reviews.apache.org/r/24299/diff/1/?file=651747#file651747line31>
> >
> > Where is this property defined? Not able to find it in code base.
>
> shwethags wrote:
> in main pom.xml. This helps to build each module separately
The main pom.xml does not have checkstyle.header.file defined currently. I did search *.xml file in codebase.
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, line 45
> > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line45>
> >
> > Below changes can make the help a little more clear.
> >
> > - The comparators are not applicable for all keys. So need to clarify that =, != is applicable for status and =, !=, <, <=, >, >= applicable for nominaltime.
> > - Would be good to have an example.
> >
>
> shwethags wrote:
> All comparators apply on all keys. = applies on nominal time to get single action. Just like in sql
>
> Example is in later section of filter
For status, only = and != makes sense.
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java, line 827
> > <https://reviews.apache.org/r/24299/diff/1/?file=651742#file651742line827>
> >
> > unintended change? Needs to be reverted.
>
> shwethags wrote:
> Is this intentional of not returning any actions by default? Even some user had questions on why its not returning any actions and then he had to set len
The commandline always returns COORD_ACTIONS_DEFAULT_LENGTH actions by default. But direct call to v2 rest API returns 0 actions if len is not specified. Robert fixed v1 to return COORD_ACTIONS_DEFAULT_LENGTH actions if len is not specified - https://issues.apache.org/jira/browse/OOZIE-1565 as it was a unintentional breaking change, but left v2 as is. I believe there was another jira to not return empty actions{} tag in that case.
What is done here is not right as this always defaults to 100.
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, line 43
> > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line43>
> >
> > default is 1000
>
> shwethags wrote:
> Its 0 in V1JobServlet.java
It is not 0. getCoordinatorJobLength(defaultLen, len); will return COORD_ACTIONS_DEFAULT_LENGTH (1000).
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review49880
-----------------------------------------------------------
On Aug. 5, 2014, 6:52 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:52 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
> pom.xml be5e84a
> src/main/resources/checkstyle.xml b75d737
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > src/main/resources/checkstyle.xml, line 31
> > <https://reviews.apache.org/r/24299/diff/1/?file=651747#file651747line31>
> >
> > Where is this property defined? Not able to find it in code base.
>
> shwethags wrote:
> in main pom.xml. This helps to build each module separately
>
> Rohini Palaniswamy wrote:
> The main pom.xml does not have checkstyle.header.file defined currently. I did search *.xml file in codebase.
>
> shwethags wrote:
> The change in pom.xml:
> <headerLocation>src/main/resources/checkstyle-header.txt</headerLocation>
Sorry. Should have checked the checkstyle maven plugin documentation. Can we remove the checkstyle changes out of this patch and keep them in the newly created checkstyle jiras?
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, line 45
> > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line45>
> >
> > Below changes can make the help a little more clear.
> >
> > - The comparators are not applicable for all keys. So need to clarify that =, != is applicable for status and =, !=, <, <=, >, >= applicable for nominaltime.
> > - Would be good to have an example.
> >
>
> shwethags wrote:
> All comparators apply on all keys. = applies on nominal time to get single action. Just like in sql
>
> Example is in later section of filter
>
> Rohini Palaniswamy wrote:
> For status, only = and != makes sense.
>
> shwethags wrote:
> Yes, but with adding more keys in the filter, this will become complicated conditions. So, we can leave it as is?
Don't have to change code. But can we at least change documentation and state that = and != are to be used for status? It would be confusing for users and there will be too smart people who will assume and expect that STATUS>WAITING should contain statuses after PREP and WAITING based on state transitions.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review49880
-----------------------------------------------------------
On Aug. 5, 2014, 6:52 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:52 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
> pom.xml be5e84a
> src/main/resources/checkstyle.xml b75d737
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review49880
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/24299/#comment87286>
nominaltime or nominal_time - to be consistent with other filter params which don't use camel casing. I see that case does not matter later due to equalsIgnorecase check, but still just to keep naming consistent.
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/24299/#comment87287>
To be removed
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/24299/#comment87288>
unintended change? Needs to be reverted.
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/24299/#comment87289>
Please remove this line
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/24299/#comment87290>
default is 1000
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/24299/#comment87291>
Below changes can make the help a little more clear.
- The comparators are not applicable for all keys. So need to clarify that =, != is applicable for status and =, !=, <, <=, >, >= applicable for nominaltime.
- Would be good to have an example.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/24299/#comment87292>
Same comment as DG_CommandLineTool.twiki
src/main/resources/checkstyle.xml
<https://reviews.apache.org/r/24299/#comment87295>
Where is this property defined? Not able to find it in code base.
- Rohini Palaniswamy
On Aug. 5, 2014, 6:52 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:52 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
> pom.xml be5e84a
> src/main/resources/checkstyle.xml b75d737
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 37
> > <https://reviews.apache.org/r/24299/diff/1/?file=651739#file651739line37>
> >
> > Why Hbase util? This means that Oozie always need have hbase-*.jar, which might cause other conflict.
>
> shwethags wrote:
> Pair is defined in a lot of dependent jars. So, wanted to re-use instead of defining our own. If we remove hbase dependency, we can switch to others or define our own. Looks ok for now
Ah. Did not notice that earlier. This needs to be changed. We cannot introduce a dependency on hbase. HBase is supposedly pluggable.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review50019
-----------------------------------------------------------
On Aug. 8, 2014, 9:24 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 9:24 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by sh...@inmobi.com.
> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 37
> > <https://reviews.apache.org/r/24299/diff/1/?file=651739#file651739line37>
> >
> > Why Hbase util? This means that Oozie always need have hbase-*.jar, which might cause other conflict.
Pair is defined in a lot of dependent jars. So, wanted to re-use instead of defining our own. If we remove hbase dependency, we can switch to others or define our own. Looks ok for now
> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 636
> > <https://reviews.apache.org/r/24299/diff/1/?file=651739#file651739line636>
> >
> > when user pass status as
> > status=<S1>[;status=<S2>]
> >
> > Then it should as check for both status.
> >
> > Eg. status=RUNNING;status=RUNNINGWITHERROR
> >
> > Should return all status matching RUNNING or RUNNINGWITHERROR.
> >
> > Not sure if it's happening here.
> >
> > From Doc.
> > "-filter <arg> status=<S1>[;status=<S2>]* or status!=<S1>[;status!=<S2>]*
> > All coordinator actions satisfying the status filters will be retrieved.
> > Positive filters '=' concatenated with 'OR' and negative filters '!=' with 'AND'."
> >
Its handled correctly:
+ case EQUALS:
+ sb.append("IN (");
+ params.putAll(appendParams(sb, filter.getValue(), pcnt));
+ sb.append(")");
+ break;
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review50019
-----------------------------------------------------------
On Aug. 5, 2014, 6:52 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:52 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
> pom.xml be5e84a
> src/main/resources/checkstyle.xml b75d737
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by sh...@inmobi.com.
> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 37
> > <https://reviews.apache.org/r/24299/diff/1/?file=651739#file651739line37>
> >
> > Why Hbase util? This means that Oozie always need have hbase-*.jar, which might cause other conflict.
>
> shwethags wrote:
> Pair is defined in a lot of dependent jars. So, wanted to re-use instead of defining our own. If we remove hbase dependency, we can switch to others or define our own. Looks ok for now
>
> Rohini Palaniswamy wrote:
> Ah. Did not notice that earlier. This needs to be changed. We cannot introduce a dependency on hbase. HBase is supposedly pluggable.
Why does oozie depend on hbase by the way?
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review50019
-----------------------------------------------------------
On Aug. 8, 2014, 9:24 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 9:24 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review50019
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/24299/#comment87528>
Why Hbase util? This means that Oozie always need have hbase-*.jar, which might cause other conflict.
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/24299/#comment87530>
when user pass status as
status=<S1>[;status=<S2>]
Then it should as check for both status.
Eg. status=RUNNING;status=RUNNINGWITHERROR
Should return all status matching RUNNING or RUNNINGWITHERROR.
Not sure if it's happening here.
From Doc.
"-filter <arg> status=<S1>[;status=<S2>]* or status!=<S1>[;status!=<S2>]*
All coordinator actions satisfying the status filters will be retrieved.
Positive filters '=' concatenated with 'OR' and negative filters '!=' with 'AND'."
- Purshotam Shah
On Aug. 5, 2014, 6:52 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:52 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
> pom.xml be5e84a
> src/main/resources/checkstyle.xml b75d737
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by sh...@inmobi.com.
> On Aug. 29, 2014, 7:14 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 36
> > <https://reviews.apache.org/r/24299/diff/3/?file=664212#file664212line36>
> >
> > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.1:provided
> > can you please check about commons-lang3, I don't think it's a part of oozie-webapp.
Didn't find anything useful in the existing libs. So, will add Pair class in oozie
> On Aug. 29, 2014, 7:14 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 640
> > <https://reviews.apache.org/r/24299/diff/3/?file=664212#file664212line640>
> >
> > "elements must be name=value or name!=value pairs");
> >
> > Minor.. Can you please support throwing error if status is not in format name=value or name!=value.
Will do
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review51896
-----------------------------------------------------------
On Aug. 19, 2014, 8:37 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 8:37 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java e3db675
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review51896
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/24299/#comment90577>
[INFO] | | +- org.apache.commons:commons-lang3:jar:3.1:provided
can you please check about commons-lang3, I don't think it's a part of oozie-webapp.
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/24299/#comment90580>
"elements must be name=value or name!=value pairs");
Minor.. Can you please support throwing error if status is not in format name=value or name!=value.
- Purshotam Shah
On Aug. 19, 2014, 8:37 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 8:37 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java e3db675
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review53004
-----------------------------------------------------------
Ship it!
Ship It!
- Purshotam Shah
On Sept. 10, 2014, 9:02 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2014, 9:02 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 249ae68
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 4d5ba71
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java cdd5000
> core/src/main/java/org/apache/oozie/util/Pair.java PRE-CREATION
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 93c9235
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 824eb80
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java d3d29aa
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/
-----------------------------------------------------------
(Updated Sept. 10, 2014, 9:02 a.m.)
Review request for oozie.
Bugs: OOZIE-1950
https://issues.apache.org/jira/browse/OOZIE-1950
Repository: oozie-git
Description
-------
Adds filter on nominal time in get coord actions
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 249ae68
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 4d5ba71
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java cdd5000
core/src/main/java/org/apache/oozie/util/Pair.java PRE-CREATION
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 93c9235
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 824eb80
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java d3d29aa
docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
Diff: https://reviews.apache.org/r/24299/diff/
Testing
-------
UTs
Thanks,
shwethags
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by sh...@inmobi.com.
> On Sept. 8, 2014, 6:50 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/util/Pair.java, line 73
> > <https://reviews.apache.org/r/24299/diff/4/?file=682415#file682415line73>
> >
> > 1.
> > If first!=null and otherPair.first=null
> > second=null and otherPair.second=null.
> >
> > Then this will return true.
> > 2.
> > If first=abc and otherPair.first=xyz
> > second=null and otherPair.second=null.
> >
> > Then this will return true.
> >
> > Is this ok?
I copied this from Hive.Pair and assumed that they must have written it right and didn't check. Yes, this will not work. Will fix
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review52619
-----------------------------------------------------------
On Sept. 8, 2014, 6:15 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2014, 6:15 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 249ae68
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 4d5ba71
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java cdd5000
> core/src/main/java/org/apache/oozie/util/Pair.java PRE-CREATION
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 93c9235
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 824eb80
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java d3d29aa
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review52619
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/Pair.java
<https://reviews.apache.org/r/24299/#comment91469>
1.
If first!=null and otherPair.first=null
second=null and otherPair.second=null.
Then this will return true.
2.
If first=abc and otherPair.first=xyz
second=null and otherPair.second=null.
Then this will return true.
Is this ok?
- Purshotam Shah
On Sept. 8, 2014, 6:15 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2014, 6:15 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 249ae68
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 4d5ba71
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java cdd5000
> core/src/main/java/org/apache/oozie/util/Pair.java PRE-CREATION
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 93c9235
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 824eb80
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java d3d29aa
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/
-----------------------------------------------------------
(Updated Sept. 8, 2014, 6:15 a.m.)
Review request for oozie.
Changes
-------
Removed dependency on external Pair. Added check on comparator for status
Bugs: OOZIE-1950
https://issues.apache.org/jira/browse/OOZIE-1950
Repository: oozie-git
Description
-------
Adds filter on nominal time in get coord actions
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 249ae68
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 4d5ba71
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java cdd5000
core/src/main/java/org/apache/oozie/util/Pair.java PRE-CREATION
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 93c9235
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 824eb80
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java d3d29aa
docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
Diff: https://reviews.apache.org/r/24299/diff/
Testing
-------
UTs
Thanks,
shwethags
Re: Review Request 24299: OOZIE-1950 Coordinator job info should
support timestamp (nominal time)
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/
-----------------------------------------------------------
(Updated Aug. 19, 2014, 8:37 a.m.)
Review request for oozie.
Changes
-------
Changed Pair class
Bugs: OOZIE-1950
https://issues.apache.org/jira/browse/OOZIE-1950
Repository: oozie-git
Description
-------
Adds filter on nominal time in get coord actions
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java e3db675
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
Diff: https://reviews.apache.org/r/24299/diff/
Testing
-------
UTs
Thanks,
shwethags
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by sh...@inmobi.com.
> On Aug. 12, 2014, 6:08 a.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, lines 59-60
> > <https://reviews.apache.org/r/24299/diff/1-2/?file=651745#file651745line59>
> >
> > Revert breaking into multiple lines.
precommit build fails with longer line:(
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review50292
-----------------------------------------------------------
On Aug. 8, 2014, 9:24 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 9:24 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/#review50292
-----------------------------------------------------------
Few minor comments. Also cannot use Pair from hbase and that needs to be changed. Please check if there is some class from commons-* or guava jars that can be used.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/24299/#comment87979>
requires -info
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/24299/#comment87980>
Revert breaking into multiple lines.
- Rohini Palaniswamy
On Aug. 8, 2014, 9:24 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24299/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 9:24 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1950
> https://issues.apache.org/jira/browse/OOZIE-1950
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Adds filter on nominal time in get coord actions
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
> docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
>
> Diff: https://reviews.apache.org/r/24299/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 24299: OOZIE-1950 Coordinator job info should support
timestamp (nominal time)
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24299/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 9:24 a.m.)
Review request for oozie.
Changes
-------
comments addressed
Bugs: OOZIE-1950
https://issues.apache.org/jira/browse/OOZIE-1950
Repository: oozie-git
Description
-------
Adds filter on nominal time in get coord actions
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 5eaf062
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java a531798
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 147bdb7
docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711
Diff: https://reviews.apache.org/r/24299/diff/
Testing
-------
UTs
Thanks,
shwethags