You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by "Shaik Nazeer Hussain (JIRA)" <ji...@apache.org> on 2016/12/30 11:27:58 UTC
[jira] [Commented] (FINERACT-357) Address the review comments for
0.6.0-incubating release
[ https://issues.apache.org/jira/browse/FINERACT-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787494#comment-15787494 ]
Shaik Nazeer Hussain commented on FINERACT-357:
-----------------------------------------------
1) I am not sure whether it is feasible to have maven repo as we are distributing deployable war file. Waiting for mentors to give their opinion.
2) I believe, integrating RAT on top level directory is unnecessary effort as either we need to duplicate the gradle scripts at top level for RAT only or we need to move the complete source and build scripts from fineract-provider to top level directory.
I think providing details how to run RAT check in readme file will suffice?
3) License.md will be renamed
4) Added jQuery license for v1.7, v1.7.1
5) Will remove the license files of source from binary and binary licenses from source
> Address the review comments for 0.6.0-incubating release
> --------------------------------------------------------
>
> Key: FINERACT-357
> URL: https://issues.apache.org/jira/browse/FINERACT-357
> Project: Apache Fineract
> Issue Type: Task
> Components: User Management
> Reporter: Shaik Nazeer Hussain
> Assignee: Shaik Nazeer Hussain
>
> As part of 0.5.0-incubating release, we got the following review comments from IPMC members which should be addressed for 0.6.0-incubating release.
> 1) Maven repo should be included in place of war file for the next release
> 2) Gradle should be integrated in the top level directory. Currently it is integrated with fineract-provider. (RAT issue)
> 3) Including License and License.md will confuse the people
> 4) The LICENSE maye be missing a license for jquery
> 5) Remove the list of software included in the binary release from the source release LICENSE file. It’s fine to have two different license files
> 6) The convenience binary file is missing LICENSE, NOTICE and DISCLAIMER in the top level, however the LICENSE and NOTICE file is inside the war and look correct
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)