You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/17 22:09:14 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2960: GOBBLIN-1120: Reinitialize HelixManager when Helix participant check …

sv2000 commented on a change in pull request #2960: GOBBLIN-1120: Reinitialize HelixManager when Helix participant check …
URL: https://github.com/apache/incubator-gobblin/pull/2960#discussion_r410493555
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixAssignedParticipantCheck.java
 ##########
 @@ -52,6 +53,8 @@
 @Slf4j
 @Alias (value = "HelixParticipantCheck")
 public class HelixAssignedParticipantCheck implements CommitStep {
+  @Getter
+  @VisibleForTesting
 
 Review comment:
   The variable is accessible via Getter in the Test class. The annotation is to indicate that the Getter is added for access inside the test class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services