You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hhbyyh <gi...@git.apache.org> on 2017/05/12 01:55:28 UTC

[GitHub] spark pull request #17940: [SPARK-20687][MLLIB] mllib.Matrices.fromBreeze ma...

Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17940#discussion_r116139610
  
    --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala ---
    @@ -46,6 +46,26 @@ class MatricesSuite extends SparkFunSuite {
         }
       }
     
    +  test("Test Breeze Conversion Bug - SPARK-20687") {
    --- End diff --
    
    specific name: Test FromBreeze when Breeze.CSCMatrix.rowIndices has trailing zeros.
    
    And move the test after another unit test "fromBreeze with sparse matrix"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org