You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/14 21:50:06 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #16064: Clean up C++ client curl configuration
michaeljmarshall opened a new pull request, #16064:
URL: https://github.com/apache/pulsar/pull/16064
### Motivation
Clean up C++ client curl configuration.
### Modifications
* Remove some settings
### Verifying this change
This is a minor change with well known scope. No additional tests are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave merged pull request #16064: Clean up C++ client curl configuration
Posted by GitBox <gi...@apache.org>.
dave2wave merged PR #16064:
URL: https://github.com/apache/pulsar/pull/16064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #16064: Clean up C++ client curl configuration
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #16064:
URL: https://github.com/apache/pulsar/pull/16064#issuecomment-1302521639
Thanks @BewareMyPower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16064: Clean up C++ client curl configuration
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16064:
URL: https://github.com/apache/pulsar/pull/16064#issuecomment-1300597317
They are restored now. I will confirm the solution soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16064: Clean up C++ client curl configuration
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16064:
URL: https://github.com/apache/pulsar/pull/16064#issuecomment-1299941386
I have confirmed it's caused by this PR and will revert it from branch-2.7 to 2.11. Though we should encourage users to use new separated `pulsar-client-cpp` and `pulsar-client-python` repos, I will confirm again for these new repos.
### Reproduce
Checkout branch-2.9, run the following command.
```bash
$ pulsar-client-cpp/docker/build-wheels.sh 3.8 cp38-cp38 manylinux2014 x86_64
```
Then `pulsar_client-2.9.3-cp38-cp38-linux_x86_64.whl` will be generated under `pulsar-client-cpp/python/dist`. Then install the wheel in a `ubuntu:20.04` container.
```bash
docker run -v $PWD:/pulsar -it ubuntu:20.04 /bin/bash
```
```bash
apt update -y
apt install -y python3 python3-pip
pip3 install /pulsar/pulsar-client-cpp/python/dist/pulsar_client-2.9.3-cp38-cp38-linux_x86_64.whl
```
Then run the following script:
```python
#!/usr/bin/env python3
from pulsar import AuthenticationOauth2
auth = AuthenticationOauth2(auth_params_string='''{
"type": "client_credentials",
"issuer_url": "https://dev-kt-aa9ne.us.auth0.com",
"client_id": "xxx",
"client_secret": "xxx"
}''')
```
Output:
```
2022-11-02 09:28:19.003 ERROR [140425586124608] AuthOauth2:222 | Response failed for getting the well-known configuration https://dev-kt-aa9ne.us.auth0.com. Error Code 77: error setting certificate verify locations:
CAfile: /etc/pki/tls/certs/ca-bundle.crt
CApath: none
```
After I reverted this PR, it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #16064: Clean up C++ client curl configuration
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #16064:
URL: https://github.com/apache/pulsar/pull/16064#issuecomment-1300454418
@BewareMyPower - this should not have been reverted. Please see this stack overflow for help solving your environment's issue: https://stackoverflow.com/questions/3160909/how-do-i-deal-with-certificates-using-curl-while-trying-to-access-an-https-url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16064: Clean up C++ client curl configuration
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16064:
URL: https://github.com/apache/pulsar/pull/16064#issuecomment-1300576232
Okay. I will confirm the solution ASAP. We should mention the CVE (even if the details were not reported) when pushing such a PR that might cause regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org