You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2016/03/02 13:33:38 UTC
[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1427
findbugs: new found old instance of DM_DEFAULT_ENCODING fixed
this quick fix to silence the findbugs
which seems to think this is a new issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack newFoundOldBug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1427.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1427
----
commit c4a9ba1cda57bcd1aaea83c44ca39629d0aae21a
Author: Daan Hoogland <da...@onecht.net>
Date: 2016-03-02T12:32:29Z
findbugs: new found old instance of DM_DEFAULT_ENCODING fixed
this quick fix to silence the findbugs
which seems to think this is a new issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-191422225
:) @swill it is the only part I typed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-204046109
#1438 covers this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-191424588
Haha. Fair enough. I will let Raja test, but otherwise it LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...
Posted by pvr9711 <gi...@git.apache.org>.
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-198490086
LGTM
Ran BVT with XS 6.5 - all the test passed with the exception of the following tests due to env issues:
test_01_create_volume - ssh issue.
test_07_list_default_iso - iso didn't exist.
test_01_test_vm_volume_snapshot - test case issue - operation is not allowed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: new found old instance of DM_DE...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-191389512
It looks like your IDE had a field day with this class. So other than the reordering of imports, adding `final` to a ton of variables and removing some unneeded brackets, this is really the only change? Right?
`
- String dir = UUID.nameUUIDFromBytes(nfsPath.getBytes()).toString();
+ final String dir = UUID.nameUUIDFromBytes(nfsPath.getBytes(getPreferredCharset())).toString();
`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---