You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/11/03 23:09:37 UTC
Review Request 27542: Add test coverage for WriteAheadStorage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Bring WriteAheadStorage up to 100% branch and instruction coverage.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review59657
-----------------------------------------------------------
Master (9ef905a) is red with this patch.
./build-support/jenkins/build.sh
:jsHint
:checkstyleMain
:compileTestJava
:processTestResources
:testClasses
:checkstyleTest[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java:0: File does not end with a newline.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.xml
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 55.115 secs
- Aurora ReviewBot
On Nov. 3, 2014, 10:11 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 10:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review60443
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 6, 2014, 1:07 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 1:07 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review60248
-----------------------------------------------------------
Ship it!
Master (5250a94) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 6, 2014, 9:07 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 9:07 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review60406
-----------------------------------------------------------
Kevin - ping?
- Bill Farner
On Nov. 6, 2014, 9:07 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 9:07 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/
-----------------------------------------------------------
(Updated Nov. 11, 2014, 3:31 a.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Rebase.
Repository: aurora
Description
-------
Bring WriteAheadStorage up to 100% branch and instruction coverage.
Diffs (updated)
-----
config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 0195557efee5dde134c265b56ffa40dd69f2b071
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 9:07 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
-------
Bring WriteAheadStorage up to 100% branch and instruction coverage.
Diffs (updated)
-----
config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review59989
-----------------------------------------------------------
Master (9847b7b) is red with this patch.
./build-support/jenkins/build.sh
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exit Log an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython>=2.6,<3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fast Run tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
- Aurora ReviewBot
On Nov. 5, 2014, 6:04 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 6:04 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 5, 2014, 8:24 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java, line 172
> > <https://reviews.apache.org/r/27542/diff/2/?file=750495#file750495line172>
> >
> > Note: none of these annotations will work since we're constructing this class without Guice.
I'll just remove them, fixing is out of scope for this review.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review60024
-----------------------------------------------------------
On Nov. 5, 2014, 6:04 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 6:04 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review60024
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java
<https://reviews.apache.org/r/27542/#comment101358>
Note: none of these annotations will work since we're constructing this class without Guice.
- Kevin Sweeney
On Nov. 5, 2014, 10:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 10:04 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/
-----------------------------------------------------------
(Updated Nov. 5, 2014, 6:04 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Needed to disable a PMD rule that forbids injecting Logger.
Repository: aurora
Description
-------
Bring WriteAheadStorage up to 100% branch and instruction coverage.
Diffs (updated)
-----
config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 5, 2014, 2:19 a.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java, line 164
> > <https://reviews.apache.org/r/27542/diff/1/?file=747813#file747813line164>
> >
> > duplicate asserts
Nope, this is two calls to mutateTasks, both return values being checked.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review59918
-----------------------------------------------------------
On Nov. 3, 2014, 10:11 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 10:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review59918
-----------------------------------------------------------
Ship it!
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
<https://reviews.apache.org/r/27542/#comment101243>
duplicate asserts
- Maxim Khutornenko
On Nov. 3, 2014, 10:11 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 10:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 10:11 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
-------
Bring WriteAheadStorage up to 100% branch and instruction coverage.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
-------
Thanks,
Bill Farner