[GitHub] flink pull request #2992: [FLINK-5325] Splitting user/system-facing API of C...

[aljoscha <gi...@git.apache.org>]

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2992#discussion_r99317280
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractConcurrentClosingRegistry.java ---
    @@ -18,37 +18,42 @@
     
     package org.apache.flink.util;
     
    +import javax.annotation.concurrent.GuardedBy;
     import java.io.Closeable;
     import java.io.IOException;
    +import java.util.HashMap;
     import java.util.Map;
     
     /**
    - * This is the abstract base class for registries that allow to register instances of {@link Closeable}, which are all
    - * closed if this registry is closed.
    + * This is the abstract base class for registries that allow to register instances of {@link Closeable}, which are
    + * all closed if this registry is closed.
      * <p>
      * Registering to an already closed registry will throw an exception and close the provided {@link Closeable}
      * <p>
      * All methods in this class are thread-safe.
      *
    - * @param <C> Type of the closeable this registers
    + * @param <C> Type of the {@link Closeable} this registers
      * @param <T> Type for potential meta data associated with the registering closeables
      */
    -public abstract class AbstractCloseableRegistry<C extends Closeable, T> implements Closeable {
    +public abstract class AbstractConcurrentClosingRegistry<C extends Closeable, T> implements Closeable {
    --- End diff --
    
    Why is this not `AbstractConcurrentClosableRegistry`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---