You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "igor-suhorukov (GitHub)" <gi...@apache.org> on 2018/12/10 00:00:28 UTC
[GitHub] [incubator-dubbo] igor-suhorukov opened pull request #2929:
Replace anonymous class with method reference
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #2929:
Replace anonymous class with method reference
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2929:
Replace anonymous class with method reference
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
@igor-suhorukov, this change leads to CI failure. It looks like lambda lost generic info (actualTypeArguments).
pls. check org.springframework.core.SerializableTypeWrapper#forGenericInterfaces
```java
public static Type[] forGenericInterfaces(final Class<?> type) {
Type[] result = new Type[type.getGenericInterfaces().length];
for (int i = 0; i < result.length; i++) {
final int index = i;
result[i] = forTypeProvider(new SimpleTypeProvider() {
@Override
public Type getType() {
return type.getGenericInterfaces()[index];
}
});
}
return result;
}
```
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2929:
Replace anonymous class with method reference
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=h1) Report
> Merging [#2929](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/107a0cc11ac8fa38986025bb7adec700d5c65482?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2929 +/- ##
==========================================
- Coverage 63.92% 63.77% -0.15%
==========================================
Files 578 578
Lines 25928 25946 +18
Branches 4539 4543 +4
==========================================
- Hits 16574 16547 -27
- Misses 7189 7232 +43
- Partials 2165 2167 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ng/zookeeper/zkclient/ZkclientZookeeperClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvemtjbGllbnQvWmtjbGllbnRab29rZWVwZXJDbGllbnQuamF2YQ==) | `62.5% <0%> (+2.97%)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <0%> (-0.32%)` | :arrow_down: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `81.95% <100%> (+0.61%)` | :arrow_up: |
| [...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1ybWkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9ybWkvUm1pUHJvdG9jb2wuamF2YQ==) | `56.41% <100%> (-1.09%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `75.75% <0%> (-8.25%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `60.86% <0%> (-6.53%)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `79.48% <0%> (-5.13%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=footer). Last update [107a0cc...d7f5a9d](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2929: Replace
anonymous class with method reference
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
@tswstarplanet
Code in master doesn't support jdk6 or 7
@igor-suhorukov
LGTM.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] igor-suhorukov commented on pull request
#2929: Replace anonymous class with method reference
Posted by "igor-suhorukov (GitHub)" <gi...@apache.org>.
@beiwei30 thank you for assistance
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #2929: Replace
anonymous class with method reference
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
LGTM now, thanks :)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org