You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 02:16:08 UTC
[GitHub] [flink] vthinkxie opened a new pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
vthinkxie opened a new pull request #13786:
URL: https://github.com/apache/flink/pull/13786
## What is the purpose of the change
ref https://issues.apache.org/jira/browse/FLINK-19764
## Brief change log
Add More Metrics to TaskManager in Web UI
## Verifying this change
- visit the TM metrics page
- verify if the TM metrics match the document https://ci.apache.org/projects/flink/flink-docs-release-1.11/ops/memory/mem_setup_tm.html
before:
after:
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (no needed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716269806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251",
"triggerID" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"triggerType" : "PUSH"
}, {
"hash" : "59796d193ea67fdc3ab7d2f9876b9fc3e9419a35",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59796d193ea67fdc3ab7d2f9876b9fc3e9419a35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6bedbd6f4cc29777a888be558030b56ba803a54 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251)
* 59796d193ea67fdc3ab7d2f9876b9fc3e9419a35 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716269806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251",
"triggerID" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6bedbd6f4cc29777a888be558030b56ba803a54 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716269806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251",
"triggerID" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"triggerType" : "PUSH"
}, {
"hash" : "59796d193ea67fdc3ab7d2f9876b9fc3e9419a35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8371",
"triggerID" : "59796d193ea67fdc3ab7d2f9876b9fc3e9419a35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6bedbd6f4cc29777a888be558030b56ba803a54 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251)
* 59796d193ea67fdc3ab7d2f9876b9fc3e9419a35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716269806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251",
"triggerID" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"triggerType" : "PUSH"
}, {
"hash" : "59796d193ea67fdc3ab7d2f9876b9fc3e9419a35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8371",
"triggerID" : "59796d193ea67fdc3ab7d2f9876b9fc3e9419a35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59796d193ea67fdc3ab7d2f9876b9fc3e9419a35 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #13786:
URL: https://github.com/apache/flink/pull/13786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716265458
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f6bedbd6f4cc29777a888be558030b56ba803a54 (Mon Oct 26 02:18:19 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vthinkxie commented on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716966483
Hi @XComp
fixed, thanks for your comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716269806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251",
"triggerID" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6bedbd6f4cc29777a888be558030b56ba803a54 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8251)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716269806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6bedbd6f4cc29777a888be558030b56ba803a54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6bedbd6f4cc29777a888be558030b56ba803a54 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vthinkxie edited a comment on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
vthinkxie edited a comment on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-716966483
Hi @XComp
fixed, thanks for your comments
new screenshot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-717727293
Thanks. I will check out the PR myself and then maybe merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-717737872
I'll merge the change. It works in Safari, Firefox and Chrome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #13786: [FLINK-19764] Add More Metrics to TaskManager in Web UI
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #13786:
URL: https://github.com/apache/flink/pull/13786#issuecomment-717414651
@vthinkxie confirmed in a private chat that the PR can be merged into master. @rmetzger it would be good if you could take over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org