You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2016/03/13 10:34:22 UTC
svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Author: markt
Date: Sun Mar 13 09:34:22 2016
New Revision: 1734771
URL: http://svn.apache.org/viewvc?rev=1734771&view=rev
Log:
Create new 8.5.x trunk from 9.0.0.M4 tag
Added:
tomcat/tc8.5.x/
tomcat/tc8.5.x/branches/
tomcat/tc8.5.x/tags/
tomcat/tc8.5.x/trunk/
- copied from r1734770, tomcat/tags/TOMCAT_9_0_0_M4/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 13.03.2016 um 14:04 schrieb Felix Schumacher:
> Am 13.03.2016 um 12:16 schrieb Rémy Maucherat:
>> 2016-03-13 11:52 GMT+01:00 Felix Schumacher <
>> felix.schumacher@internetallee.de>:
>>
>>> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>>>
>>>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>>
>>>> The task list is (probably):
>>>>>> - Switch to Java 7 for source and target
>>>>>> - Cleanup "9" version numbers in various places
>>>>>> - Resolve Java 7 issues
>>>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>>>
>>>>>> From that list, what can I do without causing conflicts ?
>>>>>>
>>>>> If you can start on the Java 7 issues that would be great. I'll
>>>>> work on
>>>>> the Servlet API stuff next and then help out with Java 7 if
>>>>> necessary.
>>>>>
>>>>> Ok, I'll do that.
>>>>>
>>>> I could help, too.
>>> I think I will try to convert the RestCsrfPreventionFilter.
>>>
>>> Sure, go ahead and fix any you find.
> What should we do with SSLParameters#setUseCipherSuitesOrder(boolean)
> in AbstractJsseEndpoint?
>
> That seems the last java 7 related issue in normal tomcat classes.
>
> I will look at the webapps code now.
The webapps issues are missing destroy() methods and usage of
GenericFilter in the filters.
I think these should be adressed, once the javax.servlet parts are resolved.
Felix
>
> Felix
>> Rémy
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Posted by Rémy Maucherat <re...@apache.org>.
2016-03-13 19:49 GMT+01:00 Mark Thomas <ma...@apache.org>:
> Wow. I can't believe how quickly we got that done. And on a Sunday
> afternoon as well.
>
> There are probably a few issues still to find but the bulk of things
> looks to be done.
>
> I'll start some new threads shortly on some admin type things we need to
> figure out.
>
> Yes, it's looking good !
One issue I have is SSLContext.setCertificateRaw doesn't work in 8.5 for
whatever reason (so OpenSSL with a keystore doesn't work). I don't quite
see the difference with trunk at this point.
Rémy
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Mark Thomas <ma...@apache.org>.
On 13/03/2016 17:18, Felix Schumacher wrote:
> Am 13.03.2016 um 15:49 schrieb Felix Schumacher:
>> Am 13.03.2016 um 14:48 schrieb Felix Schumacher:
>>> Am 13.03.2016 um 14:40 schrieb Mark Thomas:
>>>> On 13/03/2016 13:04, Felix Schumacher wrote:
>>>>> Am 13.03.2016 um 12:16 schrieb Rémy Maucherat:
>>>>>> 2016-03-13 11:52 GMT+01:00 Felix Schumacher <
>>>>>> felix.schumacher@internetallee.de>:
>>>>>>
>>>>>>> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>>>>>>>
>>>>>>>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>>>>>>
>>>>>>>> The task list is (probably):
>>>>>>>>>> - Switch to Java 7 for source and target
>>>>>>>>>> - Cleanup "9" version numbers in various places
>>>>>>>>>> - Resolve Java 7 issues
>>>>>>>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>>>>>>>
>>>>>>>>>> From that list, what can I do without causing conflicts ?
>>>>>>>>>>
>>>>>>>>> If you can start on the Java 7 issues that would be great. I'll
>>>>>>>>> work on
>>>>>>>>> the Servlet API stuff next and then help out with Java 7 if
>>>>>>>>> necessary.
>>>>>>>>>
>>>>>>>>> Ok, I'll do that.
>>>>>>>>>
>>>>>>>> I could help, too.
>>>>>>> I think I will try to convert the RestCsrfPreventionFilter.
>>>>>>>
>>>>>>> Sure, go ahead and fix any you find.
>>>>> What should we do with
>>>>> SSLParameters#setUseCipherSuitesOrder(boolean) in
>>>>> AbstractJsseEndpoint?
>>>> What does Tomcat 8 do in the equivalent code?
>>> It uses reflection to test for java 8. Will look into it. (Should
>>> have looked closer in the first place)
>> ant test compiles without an error. Let's see, if it runs without an
>> error.
> ant test runs without any error except cipher suite tests, which are
> expected on my ubuntu 14.04 setup.
Wow. I can't believe how quickly we got that done. And on a Sunday
afternoon as well.
There are probably a few issues still to find but the bulk of things
looks to be done.
I'll start some new threads shortly on some admin type things we need to
figure out.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 13.03.2016 um 15:49 schrieb Felix Schumacher:
> Am 13.03.2016 um 14:48 schrieb Felix Schumacher:
>> Am 13.03.2016 um 14:40 schrieb Mark Thomas:
>>> On 13/03/2016 13:04, Felix Schumacher wrote:
>>>> Am 13.03.2016 um 12:16 schrieb Rémy Maucherat:
>>>>> 2016-03-13 11:52 GMT+01:00 Felix Schumacher <
>>>>> felix.schumacher@internetallee.de>:
>>>>>
>>>>>> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>>>>>>
>>>>>>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>>>>>
>>>>>>> The task list is (probably):
>>>>>>>>> - Switch to Java 7 for source and target
>>>>>>>>> - Cleanup "9" version numbers in various places
>>>>>>>>> - Resolve Java 7 issues
>>>>>>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>>>>>>
>>>>>>>>> From that list, what can I do without causing conflicts ?
>>>>>>>>>
>>>>>>>> If you can start on the Java 7 issues that would be great. I'll
>>>>>>>> work on
>>>>>>>> the Servlet API stuff next and then help out with Java 7 if
>>>>>>>> necessary.
>>>>>>>>
>>>>>>>> Ok, I'll do that.
>>>>>>>>
>>>>>>> I could help, too.
>>>>>> I think I will try to convert the RestCsrfPreventionFilter.
>>>>>>
>>>>>> Sure, go ahead and fix any you find.
>>>> What should we do with
>>>> SSLParameters#setUseCipherSuitesOrder(boolean) in
>>>> AbstractJsseEndpoint?
>>> What does Tomcat 8 do in the equivalent code?
>> It uses reflection to test for java 8. Will look into it. (Should
>> have looked closer in the first place)
> ant test compiles without an error. Let's see, if it runs without an
> error.
ant test runs without any error except cipher suite tests, which are
expected on my ubuntu 14.04 setup.
Felix
>
> Felix
>>
>> Felix
>>>
>>> Mark
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 13.03.2016 um 14:48 schrieb Felix Schumacher:
> Am 13.03.2016 um 14:40 schrieb Mark Thomas:
>> On 13/03/2016 13:04, Felix Schumacher wrote:
>>> Am 13.03.2016 um 12:16 schrieb Rémy Maucherat:
>>>> 2016-03-13 11:52 GMT+01:00 Felix Schumacher <
>>>> felix.schumacher@internetallee.de>:
>>>>
>>>>> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>>>>>
>>>>>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>>>>
>>>>>> The task list is (probably):
>>>>>>>> - Switch to Java 7 for source and target
>>>>>>>> - Cleanup "9" version numbers in various places
>>>>>>>> - Resolve Java 7 issues
>>>>>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>>>>>
>>>>>>>> From that list, what can I do without causing conflicts ?
>>>>>>>>
>>>>>>> If you can start on the Java 7 issues that would be great. I'll
>>>>>>> work on
>>>>>>> the Servlet API stuff next and then help out with Java 7 if
>>>>>>> necessary.
>>>>>>>
>>>>>>> Ok, I'll do that.
>>>>>>>
>>>>>> I could help, too.
>>>>> I think I will try to convert the RestCsrfPreventionFilter.
>>>>>
>>>>> Sure, go ahead and fix any you find.
>>> What should we do with
>>> SSLParameters#setUseCipherSuitesOrder(boolean) in
>>> AbstractJsseEndpoint?
>> What does Tomcat 8 do in the equivalent code?
> It uses reflection to test for java 8. Will look into it. (Should have
> looked closer in the first place)
ant test compiles without an error. Let's see, if it runs without an error.
Felix
>
> Felix
>>
>> Mark
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 13.03.2016 um 14:40 schrieb Mark Thomas:
> On 13/03/2016 13:04, Felix Schumacher wrote:
>> Am 13.03.2016 um 12:16 schrieb Rémy Maucherat:
>>> 2016-03-13 11:52 GMT+01:00 Felix Schumacher <
>>> felix.schumacher@internetallee.de>:
>>>
>>>> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>>>>
>>>>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>>>
>>>>> The task list is (probably):
>>>>>>> - Switch to Java 7 for source and target
>>>>>>> - Cleanup "9" version numbers in various places
>>>>>>> - Resolve Java 7 issues
>>>>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>>>>
>>>>>>> From that list, what can I do without causing conflicts ?
>>>>>>>
>>>>>> If you can start on the Java 7 issues that would be great. I'll
>>>>>> work on
>>>>>> the Servlet API stuff next and then help out with Java 7 if necessary.
>>>>>>
>>>>>> Ok, I'll do that.
>>>>>>
>>>>> I could help, too.
>>>> I think I will try to convert the RestCsrfPreventionFilter.
>>>>
>>>> Sure, go ahead and fix any you find.
>> What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in
>> AbstractJsseEndpoint?
> What does Tomcat 8 do in the equivalent code?
It uses reflection to test for java 8. Will look into it. (Should have
looked closer in the first place)
Felix
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Mark Thomas <ma...@apache.org>.
On 13/03/2016 13:04, Felix Schumacher wrote:
> Am 13.03.2016 um 12:16 schrieb Rémy Maucherat:
>> 2016-03-13 11:52 GMT+01:00 Felix Schumacher <
>> felix.schumacher@internetallee.de>:
>>
>>> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>>>
>>>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>>
>>>> The task list is (probably):
>>>>>> - Switch to Java 7 for source and target
>>>>>> - Cleanup "9" version numbers in various places
>>>>>> - Resolve Java 7 issues
>>>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>>>
>>>>>> From that list, what can I do without causing conflicts ?
>>>>>>
>>>>> If you can start on the Java 7 issues that would be great. I'll
>>>>> work on
>>>>> the Servlet API stuff next and then help out with Java 7 if necessary.
>>>>>
>>>>> Ok, I'll do that.
>>>>>
>>>> I could help, too.
>>> I think I will try to convert the RestCsrfPreventionFilter.
>>>
>>> Sure, go ahead and fix any you find.
> What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in
> AbstractJsseEndpoint?
What does Tomcat 8 do in the equivalent code?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 13.03.2016 um 12:16 schrieb Rémy Maucherat:
> 2016-03-13 11:52 GMT+01:00 Felix Schumacher <
> felix.schumacher@internetallee.de>:
>
>> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>>
>>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>
>>> The task list is (probably):
>>>>> - Switch to Java 7 for source and target
>>>>> - Cleanup "9" version numbers in various places
>>>>> - Resolve Java 7 issues
>>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>>
>>>>> From that list, what can I do without causing conflicts ?
>>>>>
>>>> If you can start on the Java 7 issues that would be great. I'll work on
>>>> the Servlet API stuff next and then help out with Java 7 if necessary.
>>>>
>>>> Ok, I'll do that.
>>>>
>>> I could help, too.
>> I think I will try to convert the RestCsrfPreventionFilter.
>>
>> Sure, go ahead and fix any you find.
What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in
AbstractJsseEndpoint?
That seems the last java 7 related issue in normal tomcat classes.
I will look at the webapps code now.
Felix
> Rémy
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Posted by Rémy Maucherat <re...@apache.org>.
2016-03-13 11:52 GMT+01:00 Felix Schumacher <
felix.schumacher@internetallee.de>:
> Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
>
>> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>
>> The task list is (probably):
>>>> - Switch to Java 7 for source and target
>>>> - Cleanup "9" version numbers in various places
>>>> - Resolve Java 7 issues
>>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>>
>>>> From that list, what can I do without causing conflicts ?
>>>>
>>> If you can start on the Java 7 issues that would be great. I'll work on
>>> the Servlet API stuff next and then help out with Java 7 if necessary.
>>>
>>> Ok, I'll do that.
>>>
>> I could help, too.
> I think I will try to convert the RestCsrfPreventionFilter.
>
> Sure, go ahead and fix any you find.
Rémy
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 13.03.2016 um 11:31 schrieb Rémy Maucherat:
> 2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
>
>>> The task list is (probably):
>>> - Switch to Java 7 for source and target
>>> - Cleanup "9" version numbers in various places
>>> - Resolve Java 7 issues
>>> - Replace javax.servlet API with the classes from Tomcat 8.0
>>>
>>> From that list, what can I do without causing conflicts ?
>> If you can start on the Java 7 issues that would be great. I'll work on
>> the Servlet API stuff next and then help out with Java 7 if necessary.
>>
>> Ok, I'll do that.
I could help, too.
I think I will try to convert the RestCsrfPreventionFilter.
Felix
> Rémy
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Posted by Rémy Maucherat <re...@apache.org>.
2016-03-13 11:01 GMT+01:00 Mark Thomas <ma...@apache.org>:
> > The task list is (probably):
> > - Switch to Java 7 for source and target
> > - Cleanup "9" version numbers in various places
> > - Resolve Java 7 issues
> > - Replace javax.servlet API with the classes from Tomcat 8.0
> >
> > From that list, what can I do without causing conflicts ?
>
> If you can start on the Java 7 issues that would be great. I'll work on
> the Servlet API stuff next and then help out with Java 7 if necessary.
>
> Ok, I'll do that.
Rémy
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/
trunk/
Posted by Mark Thomas <ma...@apache.org>.
On 13/03/2016 09:57, Rémy Maucherat wrote:
> 2016-03-13 10:34 GMT+01:00 <ma...@apache.org>:
>
>> Author: markt
>> Date: Sun Mar 13 09:34:22 2016
>> New Revision: 1734771
>>
>> URL: http://svn.apache.org/viewvc?rev=1734771&view=rev
>> Log:
>> Create new 8.5.x trunk from 9.0.0.M4 tag
>>
>> Added:
>> tomcat/tc8.5.x/
>> tomcat/tc8.5.x/branches/
>> tomcat/tc8.5.x/tags/
>> tomcat/tc8.5.x/trunk/
>> - copied from r1734770, tomcat/tags/TOMCAT_9_0_0_M4/
>>
> The task list is (probably):
> - Switch to Java 7 for source and target
> - Cleanup "9" version numbers in various places
> - Resolve Java 7 issues
> - Replace javax.servlet API with the classes from Tomcat 8.0
>
> From that list, what can I do without causing conflicts ?
If you can start on the Java 7 issues that would be great. I'll work on
the Servlet API stuff next and then help out with Java 7 if necessary.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Posted by Rémy Maucherat <re...@apache.org>.
2016-03-13 10:34 GMT+01:00 <ma...@apache.org>:
> Author: markt
> Date: Sun Mar 13 09:34:22 2016
> New Revision: 1734771
>
> URL: http://svn.apache.org/viewvc?rev=1734771&view=rev
> Log:
> Create new 8.5.x trunk from 9.0.0.M4 tag
>
> Added:
> tomcat/tc8.5.x/
> tomcat/tc8.5.x/branches/
> tomcat/tc8.5.x/tags/
> tomcat/tc8.5.x/trunk/
> - copied from r1734770, tomcat/tags/TOMCAT_9_0_0_M4/
>
> The task list is (probably):
- Switch to Java 7 for source and target
- Cleanup "9" version numbers in various places
- Resolve Java 7 issues
- Replace javax.servlet API with the classes from Tomcat 8.0
>From that list, what can I do without causing conflicts ?
Rémy