You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/07/28 01:38:37 UTC
Re: Review Request 32961: Allow framework re-registeration to update
master http fields.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32961/#review93199
-----------------------------------------------------------
src/master/master.cpp (line 1850)
<https://reviews.apache.org/r/32961/#comment147516>
Anand discovered that we shouldn't be calling this in the FrameworkErrorMessage case below, where we drop the message. Looks like a bug?
- Ben Mahler
On April 14, 2015, 4:30 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32961/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 4:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1218, MESOS-2614 and MESOS-703
> https://issues.apache.org/jira/browse/MESOS-1218
> https://issues.apache.org/jira/browse/MESOS-2614
> https://issues.apache.org/jira/browse/MESOS-703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fields: 'name', 'hostname', 'failover_timeout', 'webui_url'
>
>
> Diffs
> -----
>
> src/master/master.hpp 6141917644b84edfed9836fa0a005d55a36880e3
> src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36
>
> Diff: https://reviews.apache.org/r/32961/diff/
>
>
> Testing
> -------
>
> make check.
> re-registered no_executor_framework with different 'name', 'hostname', 'failover_timeout', and 'webui_url'
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 32961: Allow framework re-registeration to update
master http fields.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On July 27, 2015, 11:38 p.m., Ben Mahler wrote:
> > src/master/master.cpp, line 1850
> > <https://reviews.apache.org/r/32961/diff/4/?file=927192#file927192line1850>
> >
> > Anand discovered that we shouldn't be calling this in the FrameworkErrorMessage case below, where we drop the message. Looks like a bug?
>
> Vinod Kone wrote:
> Definitely looks like a bug. @joris do you want to post a fix?
I think there are a couple of error cases in which we don't want to update the framework info so I have created MESOS-3169 to address this issue.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32961/#review93199
-----------------------------------------------------------
On April 14, 2015, 4:30 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32961/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 4:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1218, MESOS-2614 and MESOS-703
> https://issues.apache.org/jira/browse/MESOS-1218
> https://issues.apache.org/jira/browse/MESOS-2614
> https://issues.apache.org/jira/browse/MESOS-703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fields: 'name', 'hostname', 'failover_timeout', 'webui_url'
>
>
> Diffs
> -----
>
> src/master/master.hpp 6141917644b84edfed9836fa0a005d55a36880e3
> src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36
>
> Diff: https://reviews.apache.org/r/32961/diff/
>
>
> Testing
> -------
>
> make check.
> re-registered no_executor_framework with different 'name', 'hostname', 'failover_timeout', and 'webui_url'
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 32961: Allow framework re-registeration to update
master http fields.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 27, 2015, 11:38 p.m., Ben Mahler wrote:
> > src/master/master.cpp, line 1850
> > <https://reviews.apache.org/r/32961/diff/4/?file=927192#file927192line1850>
> >
> > Anand discovered that we shouldn't be calling this in the FrameworkErrorMessage case below, where we drop the message. Looks like a bug?
Definitely looks like a bug. @joris do you want to post a fix?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32961/#review93199
-----------------------------------------------------------
On April 14, 2015, 4:30 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32961/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 4:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1218, MESOS-2614 and MESOS-703
> https://issues.apache.org/jira/browse/MESOS-1218
> https://issues.apache.org/jira/browse/MESOS-2614
> https://issues.apache.org/jira/browse/MESOS-703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fields: 'name', 'hostname', 'failover_timeout', 'webui_url'
>
>
> Diffs
> -----
>
> src/master/master.hpp 6141917644b84edfed9836fa0a005d55a36880e3
> src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36
>
> Diff: https://reviews.apache.org/r/32961/diff/
>
>
> Testing
> -------
>
> make check.
> re-registered no_executor_framework with different 'name', 'hostname', 'failover_timeout', and 'webui_url'
>
>
> Thanks,
>
> Joris Van Remoortere
>
>