You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/01/27 18:28:49 UTC
Review Request 17397: AMBARI-4428 - Add Ambari View configuration code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17397/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Sid Wagle.
Bugs: AMBARI-4428
https://issues.apache.org/jira/browse/AMBARI-4428
Repository: ambari
Description
-------
Add the code required to read the view.xml configuration file of an Ambari View.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ParameterConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/PropertyConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ResourceConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletMappingConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ParameterConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/PropertyConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ResourceConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletMappingConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/17397/diff/
Testing
-------
New view configuration unit tests added.
All ambari-server unit tests passing:
Results :
Tests run: 1317, Failures: 0, Errors: 0, Skipped: 7
Thanks,
Tom Beerbower
Re: Review Request 17397: AMBARI-4428 - Add Ambari View configuration code.
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17397/#review32881
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 27, 2014, 12:28 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17397/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 12:28 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sid Wagle.
>
>
> Bugs: AMBARI-4428
> https://issues.apache.org/jira/browse/AMBARI-4428
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the code required to read the view.xml configuration file of an Ambari View.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ParameterConfig.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/PropertyConfig.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ResourceConfig.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletConfig.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletMappingConfig.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ParameterConfigTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/PropertyConfigTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ResourceConfigTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletConfigTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletMappingConfigTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17397/diff/
>
>
> Testing
> -------
>
> New view configuration unit tests added.
>
> All ambari-server unit tests passing:
>
> Results :
>
> Tests run: 1317, Failures: 0, Errors: 0, Skipped: 7
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 17397: AMBARI-4428 - Add Ambari View configuration code.
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17397/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 8:57 p.m.)
Review request for Ambari, Nate Cole and Sid Wagle.
Bugs: AMBARI-4428
https://issues.apache.org/jira/browse/AMBARI-4428
Repository: ambari
Description
-------
Add the code required to read the view.xml configuration file of an Ambari View.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ParameterConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/PropertyConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ResourceConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletMappingConfig.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ParameterConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/PropertyConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ResourceConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletMappingConfigTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/17397/diff/
Testing
-------
New view configuration unit tests added.
All ambari-server unit tests passing:
Results :
Tests run: 1317, Failures: 0, Errors: 0, Skipped: 7
Thanks,
Tom Beerbower