[GitHub] [incubator-superset] maloun96 commented on a change in pull request #11885: fix(event-flow-viz): handle null metadata selection

[GitBox <gi...@apache.org>]

maloun96 commented on a change in pull request #11885:
URL: https://github.com/apache/incubator-superset/pull/11885#discussion_r535873490



##########
File path: superset-frontend/src/explore/components/controls/SelectControl.jsx
##########
@@ -102,10 +102,9 @@ export default class SelectControl extends React.PureComponent {
   // Beware: This is acting like an on-click instead of an on-change
   // (firing every time user chooses vs firing only if a new option is chosen).
   onChange(opt) {
-    let optionValue = null;
+    let optionValue = this.props.multi ? [] : null;

Review comment:
       @villebro  in case that select has only 1 value it should be initialized with null, only if it can have multiple select that it should be []




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org