You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2016/03/16 17:44:22 UTC
[GitHub] brooklyn-server pull request: Make EmbeddedFelixFramework pluggabl...
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/66
Make EmbeddedFelixFramework pluggable
Needs different implementations depending on whether running in Karaf or classical. Can't have EmbeddedFelixFramework loaded in Karaf because felix bundle doesn't export org.apache.framework packages, just generic OSGi ones.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-server fix/embedded-dep
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit fb1b5a716a1cacd292dea92ef04f9d6da6e70993
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-03-16T16:41:52Z
Make EmbeddedFelixFramework pluggable
Needs different implementations depending on whether running in Karaf or classical. Can't have EmbeddedFelixFramework loaded in Karaf because felix bundle doesn't export org.apache.framework packages, just generic OSGi ones.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Make EmbeddedFelixFramework p...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-server/pull/66#issuecomment-198432796
:+1: I like it - like the move to having the common interface, and then loading the appropriate implementation based on which mode you are running in. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Make EmbeddedFelixFramework p...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/66#issuecomment-197875433
With this change next error when deploying MachineEntity is:
```
java.lang.NoClassDefFoundError: com/maxmind/db/Reader$FileMode
at com.maxmind.geoip2.DatabaseReader$Builder.<init>(DatabaseReader.java:66)
at org.apache.brooklyn.core.location.geo.MaxMind2HostGeoLookup.getDatabaseReader(MaxMind2HostGeoLookup.java:54)
at org.apache.brooklyn.core.location.geo.HostGeoInfo.findHostGeoLookupImpl(HostGeoInfo.java:161)
at org.apache.brooklyn.core.location.geo.HostGeoInfo.getDefaultLookup(HostGeoInfo.java:78)
at org.apache.brooklyn.core.location.geo.HostGeoInfo.fromIpAddress(HostGeoInfo.java:65)
at org.apache.brooklyn.core.location.geo.HostGeoInfo.fromLocation(HostGeoInfo.java:115)
at org.apache.brooklyn.location.localhost.LocalhostMachineProvisioningLocation.configure(LocalhostMachineProvisioningLocation.java:145)
at org.apache.brooklyn.location.localhost.LocalhostMachineProvisioningLocation.configure(LocalhostMachineProvisioningLocation.java:72)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Make EmbeddedFelixFramework p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Make EmbeddedFelixFramework p...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/66#issuecomment-197984633
After last commit (adding a dependency) I was able to deploy a `MachineEntity` to `byon` using
```
brooklyn.catalog:
items:
- id: machine
libraries:
- name: org.apache.brooklyn.software-base
version: 0.9.0.SNAPSHOT
item:
type: org.apache.brooklyn.entity.machine.MachineEntity
```
```
location: byon:(hosts=x.x.x.x)
services:
- type: machine
```
The application started successfully (YAY!). The UI was behaving weirdly though, sensors & tasks were not getting populated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---