[GitHub] [accumulo] jzgithub1 commented on issue #1052: Review DistributedCache usage (pretty sure it's very broken)

[GitBox <gi...@apache.org>]

jzgithub1 commented on issue #1052: Review DistributedCache usage (pretty sure it's very broken)
URL: https://github.com/apache/accumulo/issues/1052#issuecomment-481274813
 
 
   public static void setSplitFile(Job job, String file) in our KeyRangePartitioner uses Job.addCacheFile and is not used in any of our code but could be used in somebody's client code so we might break other peoples' client code if we remove it.   
   
   public static void setSplitFile(Job job, String file) in the RangePartitioner is called in the KeyRangePartitioner in the KeyRangePartitioner.setSplitFile function but nowhere else.  Removing that function could break someone's client code also.
   
   setClientProperties in ConfiguratorBase calls DistributedCacheHelper.addCacheFile(new URI(clientPropsPath), conf) which calls Job.addCacheFile too.
   
   If our interface to the Hadoop API is working for people who are using the our client API we might want to keep this code in place and test what we have.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services