You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by krichter722 <gi...@git.apache.org> on 2018/05/21 03:20:01 UTC
[GitHub] commons-fileupload pull request #14: Add missing @Override annotations
GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-fileupload/pull/14
Add missing @Override annotations
@Override annotations help to detect architectural errors and respond
quicker to method changes. Unclear why the checkstyle configuration
which includes MissingOverride passes the validation if they're missing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krichter722/commons-fileupload override
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-fileupload/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 6377a58148c7a24d890007df13ee202a818f4a34
Author: Karl-Philipp Richter <kr...@...>
Date: 2018-05-21T03:16:05Z
Add missing @Override annotations
@Override annotations help to detect architectural errors and respond
quicker to method changes. Unclear why the checkstyle configuration
which includes MissingOverride passes the validation if they're missing.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-fileupload issue #14: Add missing @Override annotations
Posted by krichter722 <gi...@git.apache.org>.
Github user krichter722 commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
> Thank you for your report. I used Eclipse'd clean up feature to implement this change instead of applying this patch. Please verify and close.
NetBeans seems to find some more :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-fileupload issue #14: Add missing @Override annotations
Posted by krichter722 <gi...@git.apache.org>.
Github user krichter722 commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
I made a mistake during rebase, the results are identical.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-fileupload pull request #14: Add missing @Override annotations
Posted by krichter722 <gi...@git.apache.org>.
Github user krichter722 closed the pull request at:
https://github.com/apache/commons-fileupload/pull/14
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-fileupload issue #14: Add missing @Override annotations
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
If you have more, please update this PR based on what is in git master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-fileupload issue #14: Add missing @Override annotations
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
Thank you for your report. I used Eclipse'd clean up feature to implement this change instead of applying this patch. Please verify and close.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-fileupload issue #14: Add missing @Override annotations
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
[](https://coveralls.io/builds/17079238)
Coverage remained the same at 77.177% when pulling **6377a58148c7a24d890007df13ee202a818f4a34 on krichter722:override** into **fc2818a419e929f60f2288898a9c815aee9e8261 on apache:master**.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org