You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/09 01:58:40 UTC

[GitHub] aaronmarkham opened a new pull request #9353: added mac gpu install; refactored windows install

aaronmarkham opened a new pull request #9353: added mac gpu install; refactored windows install
URL: https://github.com/apache/incubator-mxnet/pull/9353
 
 
   ## Description ##
   - Fixed install selector issues where certain Windows instructions were failing to appear.
   - Added Mac OS GPU installation info
   
   The install page is far from ideal - super difficult to maintain - but this should at least improve usability.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   Out of the scope of this PR.
   - [x] Code is well-documented: 
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Windows
      - Fixed config so Windows pip, virtualenv, docker, and build from source selector appears.
      - Windows > Python > GPU > build from source instructions are available now under the appropriate heading.
      - Windows > Python > CPU > pip install added
   - Mac
      - Mac > Python > GPU > Build from Source - Added Mac OS X GPU build from source instructions.
   - Various adjustments to repair validation sections.
   
   ## Comments ##
   Documents #9217 so it can probably be closed.
   Fixes #9146 (broken selector)
   
   Existing PR #8619 - will need to rebase with this update and should probably just add updated installation info to the existing section in this file instead of the separate windows_setup.md file.
   
   Windows CPU Build From Source needs validation and improved information since the existing docs really seem to focus on GPU builds only.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services