You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/12/15 17:48:57 UTC
[Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after #290 ?
#308: Diff CSS is gone in i.a.o - after #290 ?
-------------------+------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: major | Component: ui design
Version: | Resolution:
-------------------+------------------------
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Comment (by rjollos):
The issue appears to be related to a defect that was introduced just
before the release of Trac 1.0. The defect mentioned in
[trac:comment:22:ticket:5533] seems to only affect the `diff`
!WikiProcessor in Trac, a problem that can be reproduced in Bloodhound.
However, this Trac defect also appears to affect preview rendering in
Bloodhound. Applying the fix in [t 11319] fixes the issue we see with
Bloodhound preview rendering of `.diff` files, even though this issue is
not seen in Trac.
The fix will be included in Trac 1.0.1, so it looks like Bloodhound just
needs to wait for that release to get this issue fixed. Though, it would
be nice to understand: Why does this defect affect Bloodhound preview
rendering but not Trac preview rendering?
When applying or reverting the fix from [t 11319], I've found it necessary
to clear the browser cache in order to see the change takes effect (In
Chrome, go to ''Clear all browsing data'' > ''Clear the cache''). It is
not enough to restart Bloodhound and refresh the browser. This was
surprising to me since these measures are not necessary in order to see
the effect of the fix on the `diff` !WikiProcessor.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Comment (by olemis):
Replying to [comment:3 rjollos]:
> Replying to [ticket:308 olemis]:
> > Maybe it is just that Trac's diff.css is gone and not applied anymore
?
>
> I can reproduce with the latest version of the trunk. `.patch` files
render fine and `diff.css` is added to the page, so the problem is only
with `.diff` files.
JFTR , aforementioned preview page was opened in my browser since days ago
and looking fine . I refreshed it by accident minutes before reporting
this issue and it was completely broken , as can be seen . I've not
detected the cause though .
> I had thought this was an issue with Trac 1.0, but I wasn't able to
reproduce the issue in Trac 1.0.
thanks for checking that :)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Comment (by rjollos):
Opened [trachacks:#10709] for the [trachacks:PermRedirectPlugin], which
was found during investigation of the issue, though it appears to be
unrelated.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: closed
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: fixed | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Changes (by gjm):
* status: new => closed
* resolution: => fixed
Comment:
I think that this will be annoying so I have applied the patch in advance
of creating a new vendor branch. Committed in r1429787.
Thanks rjollos!
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Comment (by rjollos):
Replying to [ticket:308 olemis]:
> Maybe it is just that Trac's diff.css is gone and not applied anymore ?
I can reproduce with the latest version of the trunk. `.patch` files
render fine and `diff.css` is added to the page, so the problem is only
with `.diff` files. I had thought this was an issue with Trac 1.0, but I
wasn't able to reproduce the issue in Trac 1.0.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Changes (by olemis):
* keywords: diff file preview starter => diff file preview starter
regression
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Comment (by rjollos):
The issue first appears in r1398968 when Trac 1.0 was merged into the
trunk.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+---------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff file preview starter
------------------------+---------------------------------------
Changes (by olemis):
* keywords: => diff file preview starter
* priority: major => blocker
* cc: olemis+bh@… (added)
* milestone: => Release 4
Old description:
New description:
I was taking a look at
[attachment:ticket:139:t139_r1362098_widgets_wikipage.diff this patch] and
it looks really bad .
Maybe it is just that Trac's diff.css is gone and not applied anymore ?
Anyway , please take a look identify what happened with that and revert to
the previous working state . IMO 0.4.0 should not be released until we fix
this issue .
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #308: Diff CSS is gone in i.a.o - after
#290 ?
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#308: Diff CSS is gone in i.a.o - after #290 ?
------------------------+--------------------------------------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: closed
Priority: blocker | Milestone: Release 4
Component: ui design | Version:
Resolution: fixed | Keywords: diff file preview starter regression
------------------------+--------------------------------------------------
Changes (by gjm):
* owner: nobody => rjollos
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/308#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker