You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Julian Reschke <ju...@gmx.de> on 2009/07/06 18:01:35 UTC
Re: svn commit: r791520 - /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
Stefan,
could you please re-test
NodeReadMethodsTest.testGetPropertiesNamePatternArray()? It still fails
for me, but now with a different result.
BR, Julian
stefan@apache.org wrote:
> Author: stefan
> Date: Mon Jul 6 15:39:40 2009
> New Revision: 791520
>
> URL: http://svn.apache.org/viewvc?rev=791520&view=rev
> Log:
> JCR-2060: JSR 283: Access Nodes and Properties by Array of "NameGlob"
>
> fixed NodeImpl#getProperties(String[]) as noted in issue comment, thanks!
>
> Modified:
> jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
>
> Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
> URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java?rev=791520&r1=791519&r2=791520&view=diff
> ==============================================================================
> --- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java (original)
> +++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java Mon Jul 6 15:39:40 2009
> @@ -4795,7 +4795,7 @@
>
> ArrayList props = new ArrayList();
> // traverse children using a special filtering 'collector'
> - accept(new ChildrenCollectorFilter(nameGlobs, props, true, false, 1));
> + accept(new ChildrenCollectorFilter(nameGlobs, props, false, true, 1));
> return new PropertyIteratorAdapter(props);
> }
>
>
>
Re: svn commit: r791520 - /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
Posted by Stefan Guggisberg <st...@gmail.com>.
julian,
please see my comment [1].
cheers
stefan
[1] https://issues.apache.org/jira/browse/JCR-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728660#action_12728660
On Mon, Jul 6, 2009 at 6:01 PM, Julian Reschke<ju...@gmx.de> wrote:
> Stefan,
>
> could you please re-test
> NodeReadMethodsTest.testGetPropertiesNamePatternArray()? It still fails for
> me, but now with a different result.
>
> BR, Julian
>
> stefan@apache.org wrote:
>>
>> Author: stefan
>> Date: Mon Jul 6 15:39:40 2009
>> New Revision: 791520
>>
>> URL: http://svn.apache.org/viewvc?rev=791520&view=rev
>> Log:
>> JCR-2060: JSR 283: Access Nodes and Properties by Array of "NameGlob"
>>
>> fixed NodeImpl#getProperties(String[]) as noted in issue comment, thanks!
>>
>> Modified:
>>
>> jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
>>
>> Modified:
>> jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
>> URL:
>> http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java?rev=791520&r1=791519&r2=791520&view=diff
>>
>> ==============================================================================
>> ---
>> jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
>> (original)
>> +++
>> jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java
>> Mon Jul 6 15:39:40 2009
>> @@ -4795,7 +4795,7 @@
>> ArrayList props = new ArrayList();
>> // traverse children using a special filtering 'collector'
>> - accept(new ChildrenCollectorFilter(nameGlobs, props, true, false,
>> 1));
>> + accept(new ChildrenCollectorFilter(nameGlobs, props, false, true,
>> 1));
>> return new PropertyIteratorAdapter(props);
>> }
>>
>>
>
>