You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/12 11:03:46 UTC
[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip opened a new pull request #161: added WKWebViewOnly to Readme
machinaeXphilip opened a new pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161
added WKWebViewOnly to Readme to config Readme explanation.
### Motivation and Context
This is (afaik) needed in order to be able to upload new apps to the iOS App Store. I assume because without it both WebViews get delivered which then triggers Apples ITMS-90809: Deprecated API Usage Error on processing of the App
### Testing
try upload app to AppStoreConnect via XCode without the added xml tag and without.
with the tag: ITMS-90809: Deprecated API Usage Error
with the tag: passes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] breautek merged pull request #161: added WKWebViewOnly to Readme
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip commented on pull request #161: added WKWebViewOnly to Readme
Posted by GitBox <gi...@apache.org>.
machinaeXphilip commented on pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643332393
thanks! i commited those. indeed better wording!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] breautek commented on pull request #161: added WKWebViewOnly to Readme
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643322131
If I don't receive a second review by Monday I'll just go ahead and merge since this is a trivial change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip commented on pull request #161: added WKWebViewOnly to Readme
Posted by GitBox <gi...@apache.org>.
machinaeXphilip commented on pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643271990
> Thanks for your contribution!
>
> I would actually add a note to this preference stating that `WKWebViewOnly` only works on `cordova-ios` versions >= 5.1.0
thank you! implemented the version limitation.
is there information to be referenced about the behaviour above 5.1.0 that could be included additionally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip commented on pull request #161: added WKWebViewOnly to Readme
Posted by GitBox <gi...@apache.org>.
machinaeXphilip commented on pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643309425
awkward. sorry for the extra work.
this is what i get for multitasking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] erisu commented on a change in pull request #161: added WKWebViewOnly to Readme
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#discussion_r439483505
##########
File path: README.md
##########
@@ -65,6 +65,12 @@ WKWebView may not fully launch (the deviceready event may not fire) unless if th
<preference name="CordovaWebViewEngine" value="CDVWKWebViewEngine" />
```
+If using cordova-ios versions >= 5.1.0 you might have to include the following tag in order to only use the WKWebView (which is required for new Apps to the AppStore):
Review comment:
Here is my recommendation on wording and presentation formatting.
##########
File path: README.md
##########
@@ -65,6 +65,12 @@ WKWebView may not fully launch (the deviceready event may not fire) unless if th
<preference name="CordovaWebViewEngine" value="CDVWKWebViewEngine" />
```
+If using cordova-ios versions >= 5.1.0 you might have to include the following tag in order to only use the WKWebView (which is required for new Apps to the AppStore):
Review comment:
```suggestion
If using `cordova-ios >= 5.1.0`, it is recommended to include the following `preference` tag to only use the `WKWebView` which is a requirement for new App submissions to the AppStore:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] breautek commented on pull request #161: added WKWebViewOnly to Readme
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643294277
> you might also have to you might have to also
Think you might have doubled up some words here :)
> is there information to be referenced about the behaviour above 5.1.0 that could be included additionally?
I don't believe so... this plugin is not usable on cordova-ios@6, but that's already documented from https://github.com/apache/cordova-plugin-wkwebview-engine/commit/486e5a74ec826b88d156dafe427aabf0827162ab
There isn't an official conclusion from Apache yet, but I'm pretty sure this plugin is going to become deprecated soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org