You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by al...@apache.org on 2019/02/28 18:21:25 UTC

[beam] branch master updated: Update dataflowlib comment

This is an automated email from the ASF dual-hosted git repository.

altay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 39ad9ce  Update dataflowlib comment
     new 3040767  Merge pull request #7964 from lostluck/patch-1
39ad9ce is described below

commit 39ad9ce1ce207772487a308003683744f65eef01
Author: Robert Burke <lo...@users.noreply.github.com>
AuthorDate: Thu Feb 28 10:14:34 2019 -0800

    Update dataflowlib comment
    
    Update comment about which operators use the serialized_fn property in BeamGo.
    
    GBK also uses it, for the window fn.
---
 sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go b/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go
index a39ec0c..dc0c36b 100644
--- a/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go
+++ b/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go
@@ -80,7 +80,7 @@ type properties struct {
 	NonParallelInputs       map[string]*outputReference `json:"non_parallel_inputs,omitempty"`       // ParDo
 	OutputInfo              []output                    `json:"output_info,omitempty"`               // Source, ParDo, GBK, Flatten, Combine, WindowInto
 	ParallelInput           *outputReference            `json:"parallel_input,omitempty"`            // ParDo, GBK, Flatten, Combine, WindowInto
-	SerializedFn            string                      `json:"serialized_fn,omitempty"`             // ParDo, Combine, WindowInto
+	SerializedFn            string                      `json:"serialized_fn,omitempty"`             // ParDo, GBK, Combine, WindowInto
 
 	PubSubTopic          string `json:"pubsub_topic,omitempty"`           // Read,Write
 	PubSubSubscription   string `json:"pubsub_subscription,omitempty"`    // Read,Write