You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/11 00:37:33 UTC
[GitHub] [iceberg] liuml07 opened a new pull request, #6558: Fix example view JSON format for view spec
liuml07 opened a new pull request, #6558:
URL: https://github.com/apache/iceberg/pull/6558
There is a running example in the view format doc. It works well to explain the view format. However, the example itself is not a valid JSON data (except the comments). That may confuse readers. This simply fix that.
Validation commands to test this change:
```
sed -n '139,184p' format/view-spec.md | sed 's/=>.*//' | jq .
sed -n '190,264p' format/view-spec.md | sed 's/=>.*//' | jq .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6558: [Doc] Fix example view JSON format for view spec
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on PR #6558:
URL: https://github.com/apache/iceberg/pull/6558#issuecomment-1381114935
Thanks for the fix! And thanks for reviewing @samredai @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #6558: [Doc] Fix example view JSON format for view spec
Posted by GitBox <gi...@apache.org>.
jackye1995 merged PR #6558:
URL: https://github.com/apache/iceberg/pull/6558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] liuml07 commented on pull request #6558: [Doc] Fix example view JSON format for view spec
Posted by GitBox <gi...@apache.org>.
liuml07 commented on PR #6558:
URL: https://github.com/apache/iceberg/pull/6558#issuecomment-1378101403
Yes, I completely agree keeping the comments would be great. The JSON is mainly for elaborating the metadata file format spec, and inline comments makes that better. Also there is a specific words above calling out the `=>` part.
> The metadata directory contains View Version Metadata files. The text after '=>' symbols describes the fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] liuml07 commented on pull request #6558: [Doc] Fix example view JSON format for view spec
Posted by GitBox <gi...@apache.org>.
liuml07 commented on PR #6558:
URL: https://github.com/apache/iceberg/pull/6558#issuecomment-1378082795
CC: @anjalinorwood @nastra @samredai for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org